Re: [Qemu-devel] [PATCH] Revert "nand: Don't inherit from Sysbus"

2014-02-05 Thread Peter Crosthwaite
On Wed, Feb 5, 2014 at 6:55 PM, Andreas Färber wrote: > Am 05.02.2014 09:39, schrieb Markus Armbruster: >> This reverts commit 7426aa72c36c908a7d0eae3e38568bb0a70de479. >> >> The commit goes into a sensible direction, but it violates qdev design >> assumptions. Symptom: "info qtree" crashes for a

Re: [Qemu-devel] [PATCH] Revert "nand: Don't inherit from Sysbus"

2014-02-05 Thread Paolo Bonzini
Il 05/02/2014 14:00, Peter Maydell ha scritto: While we're talking about regressions: Paolo, do we have a good fix for the PPC boot regression yet or should we revert the patch which caused that? Yes, Antony tested the patch on Xen. I'll send the patch as soon as possible. Paolo

Re: [Qemu-devel] [PATCH] Revert "nand: Don't inherit from Sysbus"

2014-02-05 Thread Markus Armbruster
Peter Maydell writes: > On 5 February 2014 13:00, Peter Maydell wrote: >> On 5 February 2014 12:24, Markus Armbruster wrote: >>> As to why it's complicated for Peter to fix, here's what Peter wrote: >>> "That series got very big on me with complications. I think near term >>> we just proceed w

Re: [Qemu-devel] [PATCH] Revert "nand: Don't inherit from Sysbus"

2014-02-05 Thread Peter Maydell
On 5 February 2014 13:00, Peter Maydell wrote: > On 5 February 2014 12:24, Markus Armbruster wrote: >> As to why it's complicated for Peter to fix, here's what Peter wrote: >> "That series got very big on me with complications. I think near term >> we just proceed with the revert. Sorry for the

Re: [Qemu-devel] [PATCH] Revert "nand: Don't inherit from Sysbus"

2014-02-05 Thread Peter Maydell
On 5 February 2014 12:24, Markus Armbruster wrote: > As to why it's complicated for Peter to fix, here's what Peter wrote: > "That series got very big on me with complications. I think near term > we just proceed with the revert. Sorry for the delay." I have no > reason to second-guess him. > >

Re: [Qemu-devel] [PATCH] Revert "nand: Don't inherit from Sysbus"

2014-02-05 Thread Markus Armbruster
Andreas Färber writes: > Am 05.02.2014 09:39, schrieb Markus Armbruster: >> This reverts commit 7426aa72c36c908a7d0eae3e38568bb0a70de479. >> >> The commit goes into a sensible direction, but it violates qdev design >> assumptions. Symptom: "info qtree" crashes for all boards including >> the de

Re: [Qemu-devel] [PATCH] Revert "nand: Don't inherit from Sysbus"

2014-02-05 Thread Andreas Färber
Am 05.02.2014 09:39, schrieb Markus Armbruster: > This reverts commit 7426aa72c36c908a7d0eae3e38568bb0a70de479. > > The commit goes into a sensible direction, but it violates qdev design > assumptions. Symptom: "info qtree" crashes for all boards including > the device (akita, borzoi, spitz, terr

[Qemu-devel] [PATCH] Revert "nand: Don't inherit from Sysbus"

2014-02-05 Thread Markus Armbruster
This reverts commit 7426aa72c36c908a7d0eae3e38568bb0a70de479. The commit goes into a sensible direction, but it violates qdev design assumptions. Symptom: "info qtree" crashes for all boards including the device (akita, borzoi, spitz, terrier, tosa, axis-dev88). Peter Crosthwaite is working on a