Re: [Qemu-devel] [PATCH] Restore terminal attributes for tty based monitor

2010-03-09 Thread Anthony Liguori
On 02/26/2010 03:34 AM, Shahar Havivi wrote: Patch http://permalink.gmane.org/gmane.comp.emulators.qemu/63472 handle close when using tty devices (like /dev/ttyS0), yet tty based monitor are not restoring terminal attributes (as done with stdio based monitor), when closing qemu after that command

Re: [Qemu-devel] [PATCH] Restore terminal attributes for tty based monitor

2010-03-01 Thread Shahar Havivi
On Sat, Feb 27, 2010 at 09:20:28AM -0700, David S. Ahern wrote: > Date: Sat, 27 Feb 2010 09:20:28 -0700 > From: "David S. Ahern" > To: Shahar Havivi > CC: qemu-devel@nongnu.org, Dor Laor > Subject: Re: [Qemu-devel] [PATCH] Restore terminal attributes for tty based >

Re: [Qemu-devel] [PATCH] Restore terminal attributes for tty based monitor

2010-02-27 Thread David S. Ahern
On 02/27/2010 01:41 AM, Shahar Havivi wrote: > On Fri, Feb 26, 2010 at 03:19:19PM -0700, David S. Ahern wrote: >> Date: Fri, 26 Feb 2010 15:19:19 -0700 >> From: "David S. Ahern" >> To: Shahar Havivi >> CC: qemu-devel@nongnu.org, Dor Laor >> Subject

Re: [Qemu-devel] [PATCH] Restore terminal attributes for tty based monitor

2010-02-27 Thread Shahar Havivi
On Fri, Feb 26, 2010 at 03:19:19PM -0700, David S. Ahern wrote: > Date: Fri, 26 Feb 2010 15:19:19 -0700 > From: "David S. Ahern" > To: Shahar Havivi > CC: qemu-devel@nongnu.org, Dor Laor > Subject: Re: [Qemu-devel] [PATCH] Restore terminal attributes for tty based >

Re: [Qemu-devel] [PATCH] Restore terminal attributes for tty based monitor

2010-02-26 Thread David S. Ahern
On 02/26/2010 01:04 PM, Shahar Havivi wrote: > Fix codding style > --- > qemu-char.c |9 + > 1 files changed, 9 insertions(+), 0 deletions(-) > > diff --git a/qemu-char.c b/qemu-char.c > index 4169492..4533887 100644 > --- a/qemu-char.c > +++ b/qemu-char.c > @@ -1002,6 +1002,7 @@

Re: [Qemu-devel] [PATCH] Restore terminal attributes for tty based monitor

2010-02-26 Thread Shahar Havivi
Fix codding style --- qemu-char.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 4169492..4533887 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -1002,6 +1002,7 @@ static void tty_serial_init(int fd, int speed, speed, par

[Qemu-devel] [PATCH] Restore terminal attributes for tty based monitor

2010-02-26 Thread Shahar Havivi
Patch http://permalink.gmane.org/gmane.comp.emulators.qemu/63472 handle close when using tty devices (like /dev/ttyS0), yet tty based monitor are not restoring terminal attributes (as done with stdio based monitor), when closing qemu after that command: $ qemu -monitor /dev/tty the terminal is no