Re: [Qemu-devel] [PATCH] Remove unwanted crlf conversion in serial

2018-05-23 Thread Eric Blake
On 05/23/2018 11:48 AM, Patryk Olszewski wrote: This patch is here to help fix years old bug of lf being replaced with crlf in serial, which is super problematic in binary transmissions, making communication with devices through serial from guest almost impossible. Setting OPOST flag in c_oflag

Re: [Qemu-devel] [PATCH] Remove unwanted crlf conversion in serial

2018-05-23 Thread Patryk Olszewski
W dniu 23.05.2018 o 18:40, Markus Armbruster pisze: > Patryk writes: > >> W dniu 22.05.2018 o 15:07, Peter Maydell pisze: >>> On 22 May 2018 at 12:53, Markus Armbruster wrote: Patryk Olszewski writes: > Signed-off-by: Patryk Olszewski > --- > chardev/char-serial.c | 2 +-

Re: [Qemu-devel] [PATCH] Remove unwanted crlf conversion in serial

2018-05-23 Thread Markus Armbruster
Patryk writes: > W dniu 22.05.2018 o 15:07, Peter Maydell pisze: >> On 22 May 2018 at 12:53, Markus Armbruster wrote: >>> Patryk Olszewski writes: >>> Signed-off-by: Patryk Olszewski --- chardev/char-serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Qemu-devel] [PATCH] Remove unwanted crlf conversion in serial

2018-05-23 Thread Patryk
W dniu 22.05.2018 o 15:07, Peter Maydell pisze: > On 22 May 2018 at 12:53, Markus Armbruster wrote: >> Patryk Olszewski writes: >> >>> Signed-off-by: Patryk Olszewski >>> --- >>> chardev/char-serial.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/chardev/char-se

Re: [Qemu-devel] [PATCH] Remove unwanted crlf conversion in serial

2018-05-22 Thread Peter Maydell
On 22 May 2018 at 12:53, Markus Armbruster wrote: > Patryk Olszewski writes: > >> Signed-off-by: Patryk Olszewski >> --- >> chardev/char-serial.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/chardev/char-serial.c b/chardev/char-serial.c >> index feb52e5..ae548d2 1

Re: [Qemu-devel] [PATCH] Remove unwanted crlf conversion in serial

2018-05-22 Thread Markus Armbruster
Patryk Olszewski writes: > Signed-off-by: Patryk Olszewski > --- > chardev/char-serial.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/chardev/char-serial.c b/chardev/char-serial.c > index feb52e5..ae548d2 100644 > --- a/chardev/char-serial.c > +++ b/chardev/char-seri

[Qemu-devel] [PATCH] Remove unwanted crlf conversion in serial

2018-05-19 Thread Patryk Olszewski
Signed-off-by: Patryk Olszewski --- chardev/char-serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chardev/char-serial.c b/chardev/char-serial.c index feb52e5..ae548d2 100644 --- a/chardev/char-serial.c +++ b/chardev/char-serial.c @@ -139,7 +139,7 @@ static void tty_ser