Re: [Qemu-devel] [PATCH] Remove un-needed code

2010-04-12 Thread Kevin Wolf
Am 12.04.2010 14:56, schrieb Bruce Rogers: > The bdrv_set_geometry_hint call below is not needed - it's just setting what > was just read. > > Signed-off-by: Bruce Rogers Almost. ;-) I fixed that additional space for you and applied the patch to the block branch. Kevin > > diff --git a/hw/vi

Re: [Qemu-devel] [PATCH] Remove un-needed code

2010-04-12 Thread Bruce Rogers
On 4/12/2010 at 2:53 AM, Kevin Wolf wrote: > Am 10.04.2010 00:55, schrieb Bruce Rogers: >> The set_geometry_hint call below is not needed - it's just setting what was > just read. >> >> Signed-Off-By: Bruce Rogers > It needs to be "Signed-off-by" with lower-case o and b to be recognized > by

[Qemu-devel] [PATCH] Remove un-needed code

2010-04-12 Thread Bruce Rogers
The bdrv_set_geometry_hint call below is not needed - it's just setting what was just read. Signed-off-by: Bruce Rogers diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index 9915840..bc4fa77 100644 --- a/hw/virtio-blk.c +++ b/hw/virtio-blk.c @@ -494,7 +494,6 @@ VirtIODevice *virtio_blk_init(Devi

Re: [Qemu-devel] [PATCH] Remove un-needed code

2010-04-12 Thread Kevin Wolf
Am 10.04.2010 00:55, schrieb Bruce Rogers: > The set_geometry_hint call below is not needed - it's just setting what was > just read. > > Signed-Off-By: Bruce Rogers > diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c > index 9915840..bc4fa77 100644 > --- a/hw/virtio-blk.c > +++ b/hw/virtio-blk.c

[Qemu-devel] [PATCH] Remove un-needed code

2010-04-09 Thread Bruce Rogers
The set_geometry_hint call below is not needed - it's just setting what was just read. Signed-Off-By: Bruce Rogers rq = NULL; s->sector_mask = (s->conf->logical_block_size / 512) - 1; bdrv_guess_geometry(s->bs, &cylinders, &heads, &secs); -bdrv_set_geometry_hint(s->bs, cylinders, he