Re: [Qemu-devel] [PATCH] Remove magic numbers for VNC message IDs from code

2010-04-09 Thread Aurelien Jarno
On Wed, Mar 31, 2010 at 06:20:43PM +0100, Daniel P. Berrange wrote: > The code processing incoming & sending outgoing messages from/to > clients used embedded magic numbers for all message IDs. This > made the code a little hard to follow. Add constants in the vnc.h > header file for all message ID

[Qemu-devel] [PATCH] Remove magic numbers for VNC message IDs from code

2010-03-31 Thread Daniel P. Berrange
The code processing incoming & sending outgoing messages from/to clients used embedded magic numbers for all message IDs. This made the code a little hard to follow. Add constants in the vnc.h header file for all message IDs and use them in the code Signed-off-by: Daniel P. Berrange --- vnc.c |

Re: [Qemu-devel] [PATCH] Remove magic numbers for VNC message IDs from code

2010-03-31 Thread Daniel P. Berrange
On Wed, Mar 31, 2010 at 12:07:51PM -0500, Anthony Liguori wrote: > On 03/31/2010 11:45 AM, Daniel P. Berrange wrote: > >diff --git a/vnc.h b/vnc.h > >index 0a7487b..8752de0 100644 > >--- a/vnc.h > >+++ b/vnc.h > >@@ -276,6 +276,57 @@ enum { > > #define VNC_FEATURE_COPYRECT_MASK(1<< VN

Re: [Qemu-devel] [PATCH] Remove magic numbers for VNC message IDs from code

2010-03-31 Thread Anthony Liguori
On 03/31/2010 11:45 AM, Daniel P. Berrange wrote: diff --git a/vnc.h b/vnc.h index 0a7487b..8752de0 100644 --- a/vnc.h +++ b/vnc.h @@ -276,6 +276,57 @@ enum { #define VNC_FEATURE_COPYRECT_MASK(1<< VNC_FEATURE_COPYRECT) +/* Client -> Server message IDs */ +#define VNC_MSG_CLIENT_

[Qemu-devel] [PATCH] Remove magic numbers for VNC message IDs from code

2010-03-31 Thread Daniel P. Berrange
The code processing incoming & sending outgoing messages from/to clients used embedded magic numbers for all message IDs. This made the code a little hard to follow. Add constants in the vnc.h header file for all message IDs and use them in the code Signed-off-by: Daniel P. Berrange --- vnc.c |