Re: [Qemu-devel] [PATCH] QJSON: Use OBJECT_CHECK

2015-05-05 Thread Juan Quintela
Luiz Capitulino wrote: > On Tue, 05 May 2015 14:43:19 +0200 > Juan Quintela wrote: > >> Eduardo Habkost wrote: >> > On Sat, Apr 25, 2015 at 07:05:55PM +0200, Andreas Färber wrote: >> >> Am 25.04.2015 um 17:28 schrieb Eduardo Habkost: >> >> > The QJSON code used casts to (QJSON*) directly, instea

Re: [Qemu-devel] [PATCH] QJSON: Use OBJECT_CHECK

2015-05-05 Thread Luiz Capitulino
On Tue, 05 May 2015 14:43:19 +0200 Juan Quintela wrote: > Eduardo Habkost wrote: > > On Sat, Apr 25, 2015 at 07:05:55PM +0200, Andreas Färber wrote: > >> Am 25.04.2015 um 17:28 schrieb Eduardo Habkost: > >> > The QJSON code used casts to (QJSON*) directly, instead of OBJECT_CHECK. > >> > There w

Re: [Qemu-devel] [PATCH] QJSON: Use OBJECT_CHECK

2015-05-05 Thread Juan Quintela
Eduardo Habkost wrote: > On Sat, Apr 25, 2015 at 07:05:55PM +0200, Andreas Färber wrote: >> Am 25.04.2015 um 17:28 schrieb Eduardo Habkost: >> > The QJSON code used casts to (QJSON*) directly, instead of OBJECT_CHECK. >> > There were even some functions using object_dynamic_cast() calls >> > follo

Re: [Qemu-devel] [PATCH] QJSON: Use OBJECT_CHECK

2015-05-02 Thread Alexander Graf
On 01.05.15 18:23, Michael Roth wrote: > Quoting Michael Roth (2015-05-01 11:19:05) >> Quoting Eduardo Habkost (2015-04-29 07:55:48) >>> On Wed, Apr 29, 2015 at 08:38:02AM -0400, Luiz Capitulino wrote: On Mon, 27 Apr 2015 14:23:20 -0300 Eduardo Habkost wrote: > On Sat, Apr 25,

Re: [Qemu-devel] [PATCH] QJSON: Use OBJECT_CHECK

2015-05-01 Thread Luiz Capitulino
On Sat, 25 Apr 2015 12:28:06 -0300 Eduardo Habkost wrote: > The QJSON code used casts to (QJSON*) directly, instead of OBJECT_CHECK. > There were even some functions using object_dynamic_cast() calls > followed by assert(), which is exactly what OBJECT_CHECK does (by > calling object_dynamic_cast

Re: [Qemu-devel] [PATCH] QJSON: Use OBJECT_CHECK

2015-05-01 Thread Michael Roth
Quoting Michael Roth (2015-05-01 11:19:05) > Quoting Eduardo Habkost (2015-04-29 07:55:48) > > On Wed, Apr 29, 2015 at 08:38:02AM -0400, Luiz Capitulino wrote: > > > On Mon, 27 Apr 2015 14:23:20 -0300 > > > Eduardo Habkost wrote: > > > > > > > On Sat, Apr 25, 2015 at 07:05:55PM +0200, Andreas Fär

Re: [Qemu-devel] [PATCH] QJSON: Use OBJECT_CHECK

2015-05-01 Thread Michael Roth
Quoting Eduardo Habkost (2015-04-29 07:55:48) > On Wed, Apr 29, 2015 at 08:38:02AM -0400, Luiz Capitulino wrote: > > On Mon, 27 Apr 2015 14:23:20 -0300 > > Eduardo Habkost wrote: > > > > > On Sat, Apr 25, 2015 at 07:05:55PM +0200, Andreas Färber wrote: > > > > Am 25.04.2015 um 17:28 schrieb Eduar

Re: [Qemu-devel] [PATCH] QJSON: Use OBJECT_CHECK

2015-05-01 Thread Eduardo Habkost
On Wed, Apr 29, 2015 at 09:18:27PM +0200, Paolo Bonzini wrote: > On 27/04/2015 19:23, Eduardo Habkost wrote: > > Also, why do we have two JSON writers in QEMU? And why do they have > > exactly the same name? > > qobject/qjson.c could use qjson.c... but then qjson.c probably should be > changed 1)

Re: [Qemu-devel] [PATCH] QJSON: Use OBJECT_CHECK

2015-04-29 Thread Paolo Bonzini
On 27/04/2015 19:23, Eduardo Habkost wrote: > Also, why do we have two JSON writers in QEMU? And why do they have > exactly the same name? qobject/qjson.c could use qjson.c... but then qjson.c probably should be changed 1) to not use QOM 2) to use GString instead of QString, just like most other

Re: [Qemu-devel] [PATCH] QJSON: Use OBJECT_CHECK

2015-04-29 Thread Luiz Capitulino
On Wed, 29 Apr 2015 09:55:48 -0300 Eduardo Habkost wrote: > > > Also, why do we have two JSON writers in QEMU? And why do they have > > > exactly the same name? > > > > Not sure I got it, which writers? > > qjson.c and qobject/qjson.c:to_json(). Hmm, yeah, you're right.

Re: [Qemu-devel] [PATCH] QJSON: Use OBJECT_CHECK

2015-04-29 Thread Eduardo Habkost
On Wed, Apr 29, 2015 at 08:38:02AM -0400, Luiz Capitulino wrote: > On Mon, 27 Apr 2015 14:23:20 -0300 > Eduardo Habkost wrote: > > > On Sat, Apr 25, 2015 at 07:05:55PM +0200, Andreas Färber wrote: > > > Am 25.04.2015 um 17:28 schrieb Eduardo Habkost: > > > > The QJSON code used casts to (QJSON*)

Re: [Qemu-devel] [PATCH] QJSON: Use OBJECT_CHECK

2015-04-29 Thread Luiz Capitulino
On Wed, 29 Apr 2015 14:46:38 +0200 Andreas Färber wrote: > Am 29.04.2015 um 14:38 schrieb Luiz Capitulino: > > On Mon, 27 Apr 2015 14:23:20 -0300 > > Eduardo Habkost wrote: > > > >> On Sat, Apr 25, 2015 at 07:05:55PM +0200, Andreas Färber wrote: > >>> Am 25.04.2015 um 17:28 schrieb Eduardo Habk

Re: [Qemu-devel] [PATCH] QJSON: Use OBJECT_CHECK

2015-04-29 Thread Andreas Färber
Am 29.04.2015 um 14:38 schrieb Luiz Capitulino: > On Mon, 27 Apr 2015 14:23:20 -0300 > Eduardo Habkost wrote: > >> On Sat, Apr 25, 2015 at 07:05:55PM +0200, Andreas Färber wrote: >>> Am 25.04.2015 um 17:28 schrieb Eduardo Habkost: The QJSON code used casts to (QJSON*) directly, instead of OB

Re: [Qemu-devel] [PATCH] QJSON: Use OBJECT_CHECK

2015-04-29 Thread Luiz Capitulino
On Mon, 27 Apr 2015 14:23:20 -0300 Eduardo Habkost wrote: > On Sat, Apr 25, 2015 at 07:05:55PM +0200, Andreas Färber wrote: > > Am 25.04.2015 um 17:28 schrieb Eduardo Habkost: > > > The QJSON code used casts to (QJSON*) directly, instead of OBJECT_CHECK. > > > There were even some functions using

Re: [Qemu-devel] [PATCH] QJSON: Use OBJECT_CHECK

2015-04-27 Thread Eduardo Habkost
On Sat, Apr 25, 2015 at 07:05:55PM +0200, Andreas Färber wrote: > Am 25.04.2015 um 17:28 schrieb Eduardo Habkost: > > The QJSON code used casts to (QJSON*) directly, instead of OBJECT_CHECK. > > There were even some functions using object_dynamic_cast() calls > > followed by assert(), which is exac

Re: [Qemu-devel] [PATCH] QJSON: Use OBJECT_CHECK

2015-04-25 Thread Andreas Färber
Am 25.04.2015 um 17:28 schrieb Eduardo Habkost: > The QJSON code used casts to (QJSON*) directly, instead of OBJECT_CHECK. > There were even some functions using object_dynamic_cast() calls > followed by assert(), which is exactly what OBJECT_CHECK does (by > calling object_dynamic_cast_assert()).

[Qemu-devel] [PATCH] QJSON: Use OBJECT_CHECK

2015-04-25 Thread Eduardo Habkost
The QJSON code used casts to (QJSON*) directly, instead of OBJECT_CHECK. There were even some functions using object_dynamic_cast() calls followed by assert(), which is exactly what OBJECT_CHECK does (by calling object_dynamic_cast_assert()). Signed-off-by: Eduardo Habkost --- qjson.c | 10 +