Re: [Qemu-devel] [PATCH] Prevent disk data loss when closing qemu

2012-05-24 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Il 23/05/2012 08:48, Pavel Dovgaluk ha scritto: > >>> > > I'm not against your patch and it's probably 1.1 material, but there > >>> > > may > >>> > > be more shutdown logic that we're missing if you close the c

Re: [Qemu-devel] [PATCH] Prevent disk data loss when closing qemu

2012-05-23 Thread Paolo Bonzini
Il 23/05/2012 08:48, Pavel Dovgaluk ha scritto: >>> > > I'm not against your patch and it's probably 1.1 material, but there may >>> > > be more shutdown logic that we're missing if you close the console >>> > > window. >> > >> > Looks like qemu_ctrl_handler (in os-win32.c) needs to do something

Re: [Qemu-devel] [PATCH] Prevent disk data loss when closing qemu

2012-05-22 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Il 22/05/2012 10:51, Kevin Wolf ha scritto: > > Am 16.05.2012 12:16, schrieb Pavel Dovgaluk: > >> I use qemu under Windows and it has two windows when executes - console > >> and SDL ones. > >> When I close SDL

Re: [Qemu-devel] [PATCH] Prevent disk data loss when closing qemu

2012-05-22 Thread Paolo Bonzini
Il 22/05/2012 10:51, Kevin Wolf ha scritto: > Am 16.05.2012 12:16, schrieb Pavel Dovgaluk: >> I use qemu under Windows and it has two windows when executes - console and >> SDL ones. >> When I close SDL window main loop function terminates correctly, and when I >> close >> console window to term

Re: [Qemu-devel] [PATCH] Prevent disk data loss when closing qemu

2012-05-22 Thread Kevin Wolf
Am 16.05.2012 12:16, schrieb Pavel Dovgaluk: > I use qemu under Windows and it has two windows when executes - console and > SDL ones. > When I close SDL window main loop function terminates correctly, and when I > close > console window to terminate qemu then the code after main loop is not >

Re: [Qemu-devel] [PATCH] Prevent disk data loss when closing qemu

2012-05-16 Thread Pavel Dovgaluk
[mailto:riegama...@gmail.com] Sent: Wednesday, May 16, 2012 12:17 PM To: Pavel Dovgaluk Cc: qemu-devel Subject: Re: [Qemu-devel] [PATCH] Prevent disk data loss when closing qemu What's the difference of these two method to call bdrv_close_all? If you close qemu window, the main_loop will return immedi

Re: [Qemu-devel] [PATCH] Prevent disk data loss when closing qemu

2012-05-16 Thread dunrong huang
What's the difference of these two method to call bdrv_close_all? If you close qemu window, the main_loop will return immediately, and call bdrv_close_all. 2012/5/16 Pavel Dovgaluk > Prevent disk data loss when closing qemu window. > > Signed-off-by: Pavel Dovgalyuk > --- > vl.c |2 +- >

[Qemu-devel] [PATCH] Prevent disk data loss when closing qemu

2012-05-16 Thread Pavel Dovgaluk
Prevent disk data loss when closing qemu window. Signed-off-by: Pavel Dovgalyuk --- vl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vl.c b/vl.c index 23ab3a3..b6cfd29 100644 --- a/vl.c +++ b/vl.c @@ -3650,10 +3650,10 @@ int main(int argc, char **argv, char **envp)