Re: [Qemu-devel] [PATCH] PC Chipset: Improve serial divisor calculation

2018-09-11 Thread Guenter Roeck
On Tue, Sep 11, 2018 at 03:21:34PM +0200, Paolo Bonzini wrote: > On 01/09/2018 01:37, Guenter Roeck wrote: > > The patch results in an unexpected DLL register value. Here is the > > surrounding code from drivers/tty/serial/pxa.c: > > > > serial_out(up, UART_DLL, quot & 0xff); /* LS of

Re: [Qemu-devel] [PATCH] PC Chipset: Improve serial divisor calculation

2018-09-11 Thread Paolo Bonzini
On 01/09/2018 01:37, Guenter Roeck wrote: > The patch results in an unexpected DLL register value. Here is the > surrounding code from drivers/tty/serial/pxa.c: > > serial_out(up, UART_DLL, quot & 0xff); /* LS of divisor */ > > /* >* work around Errata #75 according t

Re: [Qemu-devel] [PATCH] PC Chipset: Improve serial divisor calculation

2018-08-31 Thread Guenter Roeck
Hi, On Fri, May 11, 2018 at 06:05:44PM -0600, Calvin Lee wrote: > This fixes several problems I found in the UART serial implementation. > Now all divisor values are allowed, while before divisor values of zero > and below the base baud rate were rejected. All changes are in reference > to http://