Re: [Qemu-devel] [PATCH] Minor mips-related patchlet

2006-03-13 Thread Paul Brook
> > > +void glue(op_store_T2_gpr_gpr, REG) (void) > > > +{ > > > +env->gpr[REG] = T2; > > > +RETURN(); > > > +} > > > > I don't think there's any point adding this unless it's actually used. > > The ARM target doesn't have this op either. > > Should it then be removed for other targets wher

Re: [Qemu-devel] [PATCH] Minor mips-related patchlet

2006-03-13 Thread Thiemo Seufer
On Sat, Mar 11, 2006 at 03:01:05PM +, Paul Brook wrote: > > Index: target-mips/op_mem.c > >... > > +extern void dump_sc (void); > > Having function prototypes in .c files is wrong. I added it to exec.h instead. > > > +void glue(op_store_T2_gpr_gpr, REG) (void) > > +{ > > +env->gpr[REG] =

Re: [Qemu-devel] [PATCH] Minor mips-related patchlet

2006-03-11 Thread Paul Brook
> Index: target-mips/op_mem.c >... > +extern void dump_sc (void); Having function prototypes in .c files is wrong. I added it to exec.h instead. > +void glue(op_store_T2_gpr_gpr, REG) (void) > +{ > +env->gpr[REG] = T2; > +RETURN(); > +} I don't think there's any point adding this unless

[Qemu-devel] [PATCH] Minor mips-related patchlet

2006-02-15 Thread Thiemo Seufer
Hello All, this adds a missing prototype and a store function template which is apparently unused but looks like a good thing to have around (other ports have it). Thiemo Index: target-mips/op_mem.c === RCS file: /sources/qemu/qem