Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Paolo Bonzini
On 17/06/2015 18:39, Michael S. Tsirkin wrote: > > Same machine type. Second is able to receive it. First one is not. > > Source don't know what is on the other side. If user is going to put a: > > > > --dont_send_serial_because_I_don't_care > > > > Then it can as well just disable the seria

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Michael S. Tsirkin
On Wed, Jun 17, 2015 at 06:34:55PM +0200, Juan Quintela wrote: > "Michael S. Tsirkin" wrote: > > On Wed, Jun 17, 2015 at 02:20:42PM +0200, Paolo Bonzini wrote: > >> > >> > >> On 17/06/2015 14:07, Dr. David Alan Gilbert wrote: > >> > Of course for us on RHEL our minor releases don't correspond to

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Paolo Bonzini
On 17/06/2015 18:34, Michael S. Tsirkin wrote: > > > > I just tried, set prog_if to different values, sure it failed. > > > > > > How so? It's just a byte in config space. > > Why does it fail? Because pci core migrates it and validates it > on both sides. I cannot find it, can you show me the

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > On Wed, Jun 17, 2015 at 02:20:42PM +0200, Paolo Bonzini wrote: >> >> >> On 17/06/2015 14:07, Dr. David Alan Gilbert wrote: >> > Of course for us on RHEL our minor releases don't correspond to >> > QEMU minor releases, so we already support migrating from our >> > do

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Michael S. Tsirkin
On Wed, Jun 17, 2015 at 06:16:19PM +0200, Paolo Bonzini wrote: > > > On 17/06/2015 16:50, Michael S. Tsirkin wrote: > > > > I just tried, set prog_if to different values, sure it failed. > > > > > > How so? It's just a byte in config space. Why does it fail? Because pci core migrates it and va

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Paolo Bonzini
On 17/06/2015 16:50, Michael S. Tsirkin wrote: > > > I just tried, set prog_if to different values, sure it failed. > > > > How so? It's just a byte in config space. But even then, fixing > > migration is just a side effect of keeping config space consistent for a > > given machine type (i.e.

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Michael S. Tsirkin
On Wed, Jun 17, 2015 at 02:20:30PM +0200, Paolo Bonzini wrote: > > > On 17/06/2015 13:58, Michael S. Tsirkin wrote: > > > No, it doesn't. The guest misbehaves maybe, but the migration format is > > > not affected. > > > > I just tried, set prog_if to different values, sure it failed. > > How s

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Michael S. Tsirkin
On Wed, Jun 17, 2015 at 02:20:42PM +0200, Paolo Bonzini wrote: > > > On 17/06/2015 14:07, Dr. David Alan Gilbert wrote: > > Of course for us on RHEL our minor releases don't correspond to > > QEMU minor releases, so we already support migrating from our > > downstream 7.1 (QEMU 2.1) derivative to

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Paolo Bonzini
On 17/06/2015 14:07, Dr. David Alan Gilbert wrote: > Of course for us on RHEL our minor releases don't correspond to > QEMU minor releases, so we already support migrating from our > downstream 7.1 (QEMU 2.1) derivative to our 7.0 (1.5.3) version. > And the reason for this patch series is to su

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Paolo Bonzini
On 17/06/2015 13:58, Michael S. Tsirkin wrote: > > No, it doesn't. The guest misbehaves maybe, but the migration format is > > not affected. > > I just tried, set prog_if to different values, sure it failed. How so? It's just a byte in config space. But even then, fixing migration is just a

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 17/06/2015 13:40, Dr. David Alan Gilbert wrote: > > > Like Juan, I see where you're coming from. But it's a slippery slope, > > > and upstream chose not to go down it. > > > > Whatever choice upstream may have made, that was a long time ago

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Michael S. Tsirkin
On Wed, Jun 17, 2015 at 01:55:37PM +0200, Paolo Bonzini wrote: > > > On 17/06/2015 13:54, Michael S. Tsirkin wrote: > >>> > >> > Where, in the specific case of migration? > > > > Just look at hour compat flags. > > > > > > > > For example (intentionally using serial here): > > > > {\ > >

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Paolo Bonzini
On 17/06/2015 13:54, Michael S. Tsirkin wrote: >>> > >> > Where, in the specific case of migration? > > > Just look at hour compat flags. > > > > > > For example (intentionally using serial here): > > > {\ > > > .driver = "pci-serial",\ > > > .property = "prog_i

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Michael S. Tsirkin
On Wed, Jun 17, 2015 at 01:53:11PM +0200, Paolo Bonzini wrote: > > > On 17/06/2015 13:45, Michael S. Tsirkin wrote: > >> > Where, in the specific case of migration? > > Just look at hour compat flags. > > > > For example (intentionally using serial here): > > {\ > > .driver

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Paolo Bonzini
On 17/06/2015 13:45, Michael S. Tsirkin wrote: >> > Where, in the specific case of migration? > Just look at hour compat flags. > > For example (intentionally using serial here): > {\ > .driver = "pci-serial",\ > .property = "prog_if",\ > .value=

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Michael S. Tsirkin
On Wed, Jun 17, 2015 at 01:44:12PM +0200, Paolo Bonzini wrote: > > > On 17/06/2015 13:40, Dr. David Alan Gilbert wrote: > > > Like Juan, I see where you're coming from. But it's a slippery slope, > > > and upstream chose not to go down it. > > > > Whatever choice upstream may have made, that wa

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Michael S. Tsirkin
On Wed, Jun 17, 2015 at 01:33:26PM +0200, Paolo Bonzini wrote: > > > On 17/06/2015 12:13, Michael S. Tsirkin wrote: > > On Wed, Jun 17, 2015 at 10:11:48AM +0200, Paolo Bonzini wrote: > >> > >> > >> On 17/06/2015 09:52, Michael S. Tsirkin wrote: > No, please. Upstream QEMU doesn't want to ge

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Paolo Bonzini
On 17/06/2015 13:40, Dr. David Alan Gilbert wrote: > > Like Juan, I see where you're coming from. But it's a slippery slope, > > and upstream chose not to go down it. > > Whatever choice upstream may have made, that was a long time ago > and doesn't mean it can't change. My question really is:

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 17/06/2015 12:13, Michael S. Tsirkin wrote: > > On Wed, Jun 17, 2015 at 10:11:48AM +0200, Paolo Bonzini wrote: > >> > >> > >> On 17/06/2015 09:52, Michael S. Tsirkin wrote: > No, please. Upstream QEMU doesn't want to get into judgement a

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Michael S. Tsirkin
On Wed, Jun 17, 2015 at 11:59:05AM +0100, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: > > On Wed, Jun 17, 2015 at 11:51:57AM +0100, Dr. David Alan Gilbert wrote: > > > * Juan Quintela (quint...@redhat.com) wrote: > > > > "Michael S. Tsirkin" wrote: > > > > > On We

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Paolo Bonzini
On 17/06/2015 12:13, Michael S. Tsirkin wrote: > On Wed, Jun 17, 2015 at 10:11:48AM +0200, Paolo Bonzini wrote: >> >> >> On 17/06/2015 09:52, Michael S. Tsirkin wrote: No, please. Upstream QEMU doesn't want to get into judgement about when migration quality might be "good enough" that

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Michael S. Tsirkin
On Wed, Jun 17, 2015 at 11:51:57AM +0100, Dr. David Alan Gilbert wrote: > * Juan Quintela (quint...@redhat.com) wrote: > > "Michael S. Tsirkin" wrote: > > > On Wed, Jun 17, 2015 at 10:11:48AM +0200, Paolo Bonzini wrote: > > >> > > >> > > >> On 17/06/2015 09:52, Michael S. Tsirkin wrote: > > >> >

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Wed, Jun 17, 2015 at 11:51:57AM +0100, Dr. David Alan Gilbert wrote: > > * Juan Quintela (quint...@redhat.com) wrote: > > > "Michael S. Tsirkin" wrote: > > > > On Wed, Jun 17, 2015 at 10:11:48AM +0200, Paolo Bonzini wrote: > > > >> > > > >> > >

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Michael S. Tsirkin
On Wed, Jun 17, 2015 at 12:48:00PM +0200, Juan Quintela wrote: > "Michael S. Tsirkin" wrote: > > On Wed, Jun 17, 2015 at 10:11:48AM +0200, Paolo Bonzini wrote: > >> > >> > >> On 17/06/2015 09:52, Michael S. Tsirkin wrote: > >> > > No, please. Upstream QEMU doesn't want to get into judgement abo

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > On Wed, Jun 17, 2015 at 10:11:48AM +0200, Paolo Bonzini wrote: >> >> >> On 17/06/2015 09:52, Michael S. Tsirkin wrote: >> > > No, please. Upstream QEMU doesn't want to get into judgement about when >> > > migration quality might be "good enough" that you can drop s

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Michael S. Tsirkin" wrote: > > On Wed, Jun 17, 2015 at 10:11:48AM +0200, Paolo Bonzini wrote: > >> > >> > >> On 17/06/2015 09:52, Michael S. Tsirkin wrote: > >> > > No, please. Upstream QEMU doesn't want to get into judgement about > >> > > when

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Michael S. Tsirkin
On Wed, Jun 17, 2015 at 11:26:07AM +0200, Juan Quintela wrote: > "Michael S. Tsirkin" wrote: > > On Wed, Jun 17, 2015 at 09:41:49AM +0200, Paolo Bonzini wrote: > >> > >> > >> On 16/06/2015 20:54, Dr. David Alan Gilbert (git) wrote: > >> > From: "Dr. David Alan Gilbert" > >> > > >> > Older QEMU

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Michael S. Tsirkin
On Wed, Jun 17, 2015 at 10:11:48AM +0200, Paolo Bonzini wrote: > > > On 17/06/2015 09:52, Michael S. Tsirkin wrote: > > > No, please. Upstream QEMU doesn't want to get into judgement about when > > > migration quality might be "good enough" that you can drop subsections. > > > It's one thing to

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 17/06/2015 10:37, Dr. David Alan Gilbert wrote: > >> > On 16/06/2015 20:54, Dr. David Alan Gilbert (git) wrote: > >> > > From: "Dr. David Alan Gilbert" > >> > > > >> > > Older QEMUs dont understand the new (sub)sections that > >> > > may be

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > On Wed, Jun 17, 2015 at 09:41:49AM +0200, Paolo Bonzini wrote: >> >> >> On 16/06/2015 20:54, Dr. David Alan Gilbert (git) wrote: >> > From: "Dr. David Alan Gilbert" >> > >> > Older QEMUs dont understand the new (sub)sections that >> > may be generated in the seria

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Tue, Jun 16, 2015 at 07:54:09PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Older QEMUs dont understand the new (sub)sections that > > may be generated in the serial device. Limit their generation > > t

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Paolo Bonzini
On 17/06/2015 10:37, Dr. David Alan Gilbert wrote: >> > On 16/06/2015 20:54, Dr. David Alan Gilbert (git) wrote: >> > > From: "Dr. David Alan Gilbert" >> > > >> > > Older QEMUs dont understand the new (sub)sections that >> > > may be generated in the serial device. Limit their generation >> >

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 16/06/2015 20:54, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Older QEMUs dont understand the new (sub)sections that > > may be generated in the serial device. Limit their generation > > to newer machine

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Paolo Bonzini
On 17/06/2015 09:52, Michael S. Tsirkin wrote: > > No, please. Upstream QEMU doesn't want to get into judgement about when > > migration quality might be "good enough" that you can drop subsections. > > It's one thing to perfect the .needed functions to make the appearance > > of subsections as

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Michael S. Tsirkin
On Wed, Jun 17, 2015 at 09:41:49AM +0200, Paolo Bonzini wrote: > > > On 16/06/2015 20:54, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Older QEMUs dont understand the new (sub)sections that > > may be generated in the serial device. Limit their generation > >

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Paolo Bonzini
On 16/06/2015 20:54, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Older QEMUs dont understand the new (sub)sections that > may be generated in the serial device. Limit their generation > to newer machine types. > > Signed-off-by: Dr. David Alan Gilbert No, pleas

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Michael S. Tsirkin
On Wed, Jun 17, 2015 at 09:11:56AM +0200, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Wed, Jun 17, 2015 at 08:52:42AM +0200, Markus Armbruster wrote: > >> "Dr. David Alan Gilbert (git)" writes: > >> > >> > From: "Dr. David Alan Gilbert" > >> > > >> > Older QEMUs dont under

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Wed, Jun 17, 2015 at 08:52:42AM +0200, Markus Armbruster wrote: >> "Dr. David Alan Gilbert (git)" writes: >> >> > From: "Dr. David Alan Gilbert" >> > >> > Older QEMUs dont understand the new (sub)sections that >> > may be generated in the serial device. Limi

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-16 Thread Michael S. Tsirkin
On Wed, Jun 17, 2015 at 08:52:42AM +0200, Markus Armbruster wrote: > "Dr. David Alan Gilbert (git)" writes: > > > From: "Dr. David Alan Gilbert" > > > > Older QEMUs dont understand the new (sub)sections that > > may be generated in the serial device. Limit their generation > > to newer machine

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-16 Thread Markus Armbruster
"Dr. David Alan Gilbert (git)" writes: > From: "Dr. David Alan Gilbert" > > Older QEMUs dont understand the new (sub)sections that > may be generated in the serial device. Limit their generation > to newer machine types. Please explain briefly what state migration can lose with old machine ty

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-16 Thread Michael S. Tsirkin
On Tue, Jun 16, 2015 at 07:54:09PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Older QEMUs dont understand the new (sub)sections that > may be generated in the serial device. Limit their generation > to newer machine types. > > Signed-off-by: Dr. David Alan

[Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-16 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Older QEMUs dont understand the new (sub)sections that may be generated in the serial device. Limit their generation to newer machine types. Signed-off-by: Dr. David Alan Gilbert --- hw/char/serial.c | 19 +-- hw/i386/pc_piix.c|