Re: [Qemu-devel] [PATCH] Migration+TLS: Fix crash due to double cleanup

2018-05-02 Thread Daniel P . Berrangé
On Mon, Apr 30, 2018 at 07:59:43PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > During a TLS connect we see: > migration_channel_connect calls > migration_tls_channel_connect > (calls after TLS setup) > migration_channel_connect > > My previous error ha

Re: [Qemu-devel] [PATCH] Migration+TLS: Fix crash due to double cleanup

2018-05-02 Thread Peter Krempa
On Mon, Apr 30, 2018 at 19:59:43 +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > During a TLS connect we see: > migration_channel_connect calls > migration_tls_channel_connect > (calls after TLS setup) > migration_channel_connect > > My previous error hand

Re: [Qemu-devel] [PATCH] Migration+TLS: Fix crash due to double cleanup

2018-05-01 Thread Daniel P . Berrangé
On Tue, May 01, 2018 at 12:21:18PM +0100, Daniel P. Berrangé wrote: > On Tue, May 01, 2018 at 11:57:25AM +0100, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > On Tue, May 01, 2018 at 11:00:35AM +0100, Daniel P. Berrangé wrote: > > > > On Mon, Apr 30, 2018

Re: [Qemu-devel] [PATCH] Migration+TLS: Fix crash due to double cleanup

2018-05-01 Thread Daniel P . Berrangé
On Tue, May 01, 2018 at 11:57:25AM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > On Tue, May 01, 2018 at 11:00:35AM +0100, Daniel P. Berrangé wrote: > > > On Mon, Apr 30, 2018 at 07:59:43PM +0100, Dr. David Alan Gilbert (git) > > > wrote: > > > > From

Re: [Qemu-devel] [PATCH] Migration+TLS: Fix crash due to double cleanup

2018-05-01 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Tue, May 01, 2018 at 11:00:35AM +0100, Daniel P. Berrangé wrote: > > On Mon, Apr 30, 2018 at 07:59:43PM +0100, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > During a TLS connect we see: > > > migr

Re: [Qemu-devel] [PATCH] Migration+TLS: Fix crash due to double cleanup

2018-05-01 Thread Daniel P . Berrangé
On Tue, May 01, 2018 at 11:00:35AM +0100, Daniel P. Berrangé wrote: > On Mon, Apr 30, 2018 at 07:59:43PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > During a TLS connect we see: > > migration_channel_connect calls > > migration_tls_channel_connect > >

Re: [Qemu-devel] [PATCH] Migration+TLS: Fix crash due to double cleanup

2018-05-01 Thread Daniel P . Berrangé
On Mon, Apr 30, 2018 at 07:59:43PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > During a TLS connect we see: > migration_channel_connect calls > migration_tls_channel_connect > (calls after TLS setup) > migration_channel_connect > > My previous error ha

[Qemu-devel] [PATCH] Migration+TLS: Fix crash due to double cleanup

2018-04-30 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" During a TLS connect we see: migration_channel_connect calls migration_tls_channel_connect (calls after TLS setup) migration_channel_connect My previous error handling fix made migration_channel_connect call migrate_fd_connect in all cases; unfortunately th