Re: [Qemu-devel] [PATCH] Makefile: simplify qapi-py definition with wildcard

2019-05-21 Thread Wei Yang
On Tue, May 21, 2019 at 08:36:42PM -0500, Eric Blake wrote: >On 5/21/19 7:53 PM, Wei Yang wrote: >> On Tue, May 21, 2019 at 05:28:27PM +0200, Markus Armbruster wrote: >>> Eric Blake writes: >>> On 5/21/19 3:12 AM, Wei Yang wrote: > All the python script in scripts/qapi is used to generate

Re: [Qemu-devel] [PATCH] Makefile: simplify qapi-py definition with wildcard

2019-05-21 Thread Eric Blake
On 5/21/19 7:53 PM, Wei Yang wrote: > On Tue, May 21, 2019 at 05:28:27PM +0200, Markus Armbruster wrote: >> Eric Blake writes: >> >>> On 5/21/19 3:12 AM, Wei Yang wrote: All the python script in scripts/qapi is used to generate qapi code. Use wildcard to simplify it. Signed-off

Re: [Qemu-devel] [PATCH] Makefile: simplify qapi-py definition with wildcard

2019-05-21 Thread Wei Yang
On Tue, May 21, 2019 at 05:28:27PM +0200, Markus Armbruster wrote: >Eric Blake writes: > >> On 5/21/19 3:12 AM, Wei Yang wrote: >>> All the python script in scripts/qapi is used to generate qapi code. Use >>> wildcard to simplify it. >>> >>> Signed-off-by: Wei Yang >>> --- >>> Makefile | 8 +---

Re: [Qemu-devel] [PATCH] Makefile: simplify qapi-py definition with wildcard

2019-05-21 Thread Wei Yang
On Tue, May 21, 2019 at 07:00:12AM -0500, Eric Blake wrote: >On 5/21/19 3:12 AM, Wei Yang wrote: >> All the python script in scripts/qapi is used to generate qapi code. Use >> wildcard to simplify it. >> >> Signed-off-by: Wei Yang >> --- >> Makefile | 8 +--- >> 1 file changed, 1 insertion(+

Re: [Qemu-devel] [PATCH] Makefile: simplify qapi-py definition with wildcard

2019-05-21 Thread Markus Armbruster
Eric Blake writes: > On 5/21/19 3:12 AM, Wei Yang wrote: >> All the python script in scripts/qapi is used to generate qapi code. Use >> wildcard to simplify it. >> >> Signed-off-by: Wei Yang >> --- >> Makefile | 8 +--- >> 1 file changed, 1 insertion(+), 7 deletions(-) > > I'm not a fan of

Re: [Qemu-devel] [PATCH] Makefile: simplify qapi-py definition with wildcard

2019-05-21 Thread Eric Blake
On 5/21/19 3:12 AM, Wei Yang wrote: > All the python script in scripts/qapi is used to generate qapi code. Use > wildcard to simplify it. > > Signed-off-by: Wei Yang > --- > Makefile | 8 +--- > 1 file changed, 1 insertion(+), 7 deletions(-) I'm not a fan of $(wildcard). It makes your tarba

[Qemu-devel] [PATCH] Makefile: simplify qapi-py definition with wildcard

2019-05-21 Thread Wei Yang
All the python script in scripts/qapi is used to generate qapi code. Use wildcard to simplify it. Signed-off-by: Wei Yang --- Makefile | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/Makefile b/Makefile index 155f066a20..38b74782d9 100644 --- a/Makefile +++ b/Makefile