Re: [Qemu-devel] [PATCH] Makefile: Install qmp-events.txt

2014-06-26 Thread Eric Blake
On 06/26/2014 07:25 AM, Paolo Bonzini wrote: > Il 26/06/2014 15:17, Luiz Capitulino ha scritto: >>> > We're really close to hard freeze and by extension the release. Do >>> > _not_ strive for perfection. Get something that is mostly okay and is >>> > an obvious patch. We'll then have 3 weeks to

Re: [Qemu-devel] [PATCH] Makefile: Install qmp-events.txt

2014-06-26 Thread Paolo Bonzini
Il 26/06/2014 18:25, Eric Blake ha scritto: Actually, there is a second new event on queue right now: https://lists.gnu.org/archive/html/qemu-devel/2014-06/msg06561.html Ok. FWIW, I consider that series a bugfix so it can go in after hard freeze. Same for the patch that lets management recon

Re: [Qemu-devel] [PATCH] Makefile: Install qmp-events.txt

2014-06-26 Thread Eric Blake
On 06/26/2014 07:01 AM, Paolo Bonzini wrote: > Il 26/06/2014 14:46, Luiz Capitulino ha scritto: >>> > >>> > Michal's hack at least ensures that we have event documentation, >>> even if >>> > the format changed compared to the 2.0 docs, and even if we don't have >>> > time to get something better in

Re: [Qemu-devel] [PATCH] Makefile: Install qmp-events.txt

2014-06-26 Thread Paolo Bonzini
Il 26/06/2014 15:17, Luiz Capitulino ha scritto: > We're really close to hard freeze and by extension the release. Do > _not_ strive for perfection. Get something that is mostly okay and is > an obvious patch. We'll then have 3 weeks to do documentation patches. The hard freeze argument is a

Re: [Qemu-devel] [PATCH] Makefile: Install qmp-events.txt

2014-06-26 Thread Luiz Capitulino
On Thu, 26 Jun 2014 15:14:01 +0200 Paolo Bonzini wrote: > Il 26/06/2014 15:11, Eric Blake ha scritto: > >> > > >> > Can we just revert to the pre-conversion qmp-events.txt file? This is > >> > similar to the situation with qmp-commands.hx. > > As in, carrying redundant information between two fi

Re: [Qemu-devel] [PATCH] Makefile: Install qmp-events.txt

2014-06-26 Thread Paolo Bonzini
Il 26/06/2014 15:11, Eric Blake ha scritto: > > Can we just revert to the pre-conversion qmp-events.txt file? This is > similar to the situation with qmp-commands.hx. As in, carrying redundant information between two files? True that it's no worse than qmp-commands.hx; it would also ensure we

Re: [Qemu-devel] [PATCH] Makefile: Install qmp-events.txt

2014-06-26 Thread Paolo Bonzini
Il 26/06/2014 14:46, Luiz Capitulino ha scritto: > > Michal's hack at least ensures that we have event documentation, even if > the format changed compared to the 2.0 docs, and even if we don't have > time to get something better in place before 2.1 goes out. So all of > this conversation on way

Re: [Qemu-devel] [PATCH] Makefile: Install qmp-events.txt

2014-06-26 Thread Luiz Capitulino
On Wed, 25 Jun 2014 14:13:37 -0600 Eric Blake wrote: > On 06/25/2014 01:50 PM, Luiz Capitulino wrote: > > >> Then again, qmp-commands.txt is generated from qmp-commands.hx, which > >> duplicates information already in qapi-schema.json (and friends, now). > >> Would it be better to just install t

Re: [Qemu-devel] [PATCH] Makefile: Install qmp-events.txt

2014-06-25 Thread Eric Blake
On 06/25/2014 01:50 PM, Luiz Capitulino wrote: >> Then again, qmp-commands.txt is generated from qmp-commands.hx, which >> duplicates information already in qapi-schema.json (and friends, now). >> Would it be better to just install the .json files? Is it time to >> finally bite the bullet and fig

Re: [Qemu-devel] [PATCH] Makefile: Install qmp-events.txt

2014-06-25 Thread Luiz Capitulino
On Wed, 25 Jun 2014 07:56:51 -0600 Eric Blake wrote: > On 06/25/2014 03:30 AM, Michal Privoznik wrote: > > Since fe069d9d5946 the qmp-events.txt does not exist anymore. This is > > unhappy as users still may want to know what events they can await > > from qemu. > > The .json files are a better

Re: [Qemu-devel] [PATCH] Makefile: Install qmp-events.txt

2014-06-25 Thread Markus Armbruster
Eric Blake writes: > On 06/25/2014 03:30 AM, Michal Privoznik wrote: >> Since fe069d9d5946 the qmp-events.txt does not exist anymore. This is >> unhappy as users still may want to know what events they can await >> from qemu. > > The .json files are a better contract of what is supported, anyways

Re: [Qemu-devel] [PATCH] Makefile: Install qmp-events.txt

2014-06-25 Thread Eric Blake
On 06/25/2014 03:30 AM, Michal Privoznik wrote: > Since fe069d9d5946 the qmp-events.txt does not exist anymore. This is > unhappy as users still may want to know what events they can await > from qemu. The .json files are a better contract of what is supported, anyways. > > Signed-off-by: Michal

Re: [Qemu-devel] [PATCH] Makefile: Install qmp-events.txt

2014-06-25 Thread Michal Privoznik
On 25.06.2014 11:34, Paolo Bonzini wrote: Il 25/06/2014 11:30, Michal Privoznik ha scritto: Since fe069d9d5946 the qmp-events.txt does not exist anymore. This is unhappy as users still may want to know what events they can await from qemu. hxtool however doesn't understand the json format. :(

Re: [Qemu-devel] [PATCH] Makefile: Install qmp-events.txt

2014-06-25 Thread Paolo Bonzini
Il 25/06/2014 11:30, Michal Privoznik ha scritto: Since fe069d9d5946 the qmp-events.txt does not exist anymore. This is unhappy as users still may want to know what events they can await from qemu. hxtool however doesn't understand the json format. :( I guess for now we could just revert the

[Qemu-devel] [PATCH] Makefile: Install qmp-events.txt

2014-06-25 Thread Michal Privoznik
Since fe069d9d5946 the qmp-events.txt does not exist anymore. This is unhappy as users still may want to know what events they can await from qemu. Signed-off-by: Michal Privoznik --- Makefile | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 145a