Re: [Qemu-devel] [PATCH] MIPS Initial support of Godson-3a multicore CPU

2010-12-07 Thread chen huacai
1, signed-off-by and reviewed-by should put after the introduction and before the code, not at first. 2, You'd better split the big patch to 2~3 small patches, E.g. CPU definition and board emulation should be split. The format of email title will be [Patch 0/3], [Patch 1/3] and so on. [Patch 0/3]

[Qemu-devel] [PATCH] MIPS Initial support of Godson-3a multicore CPU

2010-12-07 Thread Jin Guojie
Signed-off-by: "Jin Guojie" Reviewed-by: "Gao Xiang" Reviewed-by: "Chen Huacai" A patch for Godson-3a CPU simulation. Godson-3a is a newly developed MIPS-III like, multicore CPU by ICT, China. We believe this patch could be helpful for other Godson developers. For you review. Any comment is

Re: [Qemu-devel] [patch] MIPS Initial support of Godson-3a multicore CPU

2010-12-01 Thread chen huacai
I think you'd better configure your smtp account and then use git send-email .patch to send patchs. In this way maintainer and other developers can easily review and comment your patch. Suggest you resend it. On Wed, Dec 1, 2010 at 11:10 AM, Jin Guojie wrote: > Aurelien, >  Attached is a patc

[Qemu-devel] [patch] MIPS Initial support of Godson-3a multicore CPU

2010-11-30 Thread Jin Guojie
Aurelien, Attached is a patch for Godson-3a CPU support. Godson-3a is a newly developed MIPS-III like, multicore CPU by ICT, China. For you review. Any comment is welcomed. Jin Guojie www.loongson.cn 0001-MIPS-Initial-support-of-Godson-3a-multicore-CPU.patch Description: Binary data