Re: [Qemu-devel] [PATCH] MIPS: Translate breaks and traps into the appropriate signal

2013-01-10 Thread Meador Inge
On 01/10/2013 04:12 PM, Peter Maydell wrote: > This is an OS/ABI specific define, right? I don't think it > belongs in the target-mips header file. Since it only has one > user, I think you could reasonably just put it in linux-user/main.c. The enum will only be used in the MIPS CPU loop. I orig

Re: [Qemu-devel] [PATCH] MIPS: Translate breaks and traps into the appropriate signal

2013-01-10 Thread Meador Inge
On 01/10/2013 03:57 PM, Stefan Weil wrote: > please check your patch before submitting it to qemu-devel. > See also http://wiki.qemu.org/Contribute/SubmitAPatch. Ah, thanks for the pointer. I have fixed the style violations. -- Meador Inge CodeSourcery / Mentor Embedded

Re: [Qemu-devel] [PATCH] MIPS: Translate breaks and traps into the appropriate signal

2013-01-10 Thread Peter Maydell
On 10 January 2013 21:46, Meador Inge wrote: > --- a/target-mips/cpu.h > +++ b/target-mips/cpu.h > @@ -620,6 +620,12 @@ enum { > /* Dummy exception for conditional stores. */ > #define EXCP_SC 0x100 > > +/* Break codes */ > +enum { > +BRK_OVERFLOW = 6, > +BRK_DIVZERO = 7 > +}; This is

Re: [Qemu-devel] [PATCH] MIPS: Translate breaks and traps into the appropriate signal

2013-01-10 Thread Stefan Weil
Am 10.01.2013 22:46, schrieb Meador Inge: GCC and GAS are capable of generating traps or breaks to check for division by zero. Additionally, GAS is capable of generating traps or breaks to check for overflow on certain division and multiplication operations. The Linux kernel translates these tr

[Qemu-devel] [PATCH] MIPS: Translate breaks and traps into the appropriate signal

2013-01-10 Thread Meador Inge
GCC and GAS are capable of generating traps or breaks to check for division by zero. Additionally, GAS is capable of generating traps or breaks to check for overflow on certain division and multiplication operations. The Linux kernel translates these traps and breaks into signals. This patch imp