Re: [Qemu-devel] [PATCH] MIPS/system: MTC0 single-stepping PC update fix

2012-06-12 Thread Richard Henderson
On 2012-06-07 18:05, Maciej W. Rozycki wrote: > if (env->singlestep_enabled && ctx.bstate != BS_BRANCH) { > -save_cpu_state(&ctx, ctx.bstate == BS_NONE); > +save_cpu_state(&ctx, ctx.bstate != BS_EXCP); > gen_helper_0i(raise_exception, EXCP_DEBUG); Reviewed-by: Richard

[Qemu-devel] [PATCH] MIPS/system: MTC0 single-stepping PC update fix

2012-06-07 Thread Maciej W. Rozycki
Some MTC0 (and possibly other) instructions switch to the BS_STOP state to terminate the current translation block, so that the state transition of the simulated CPU resulting from the CP0 operation takes effect with the following instruction. This happens for "mtc0 ,c0_config" for example. Wh