Re: [Qemu-devel] [PATCH] Improve gcc 3 checking

2006-12-18 Thread Anthony Liguori
Paul Brook wrote: If they explicitly specific an invalid --cc=, the checks will get triggered (but in the past, we would have bailed). That's what I'm objecting to. If I do: ./configure --cc=gcc4 I expect configure to either use gcc4 or fail with an error. Preferably the latter, but I'm

Re: [Qemu-devel] [PATCH] Improve gcc 3 checking

2006-12-18 Thread Paul Brook
> If they explicitly specific an invalid --cc=, the checks will get > triggered (but in the past, we would have bailed). That's what I'm objecting to. If I do: ./configure --cc=gcc4 I expect configure to either use gcc4 or fail with an error. Preferably the latter, but I'm open to persuasion.

Re: [Qemu-devel] [PATCH] Improve gcc 3 checking

2006-12-18 Thread Anthony Liguori
Paul Brook wrote: On Tuesday 19 December 2006 02:25, Anthony Liguori wrote: +gcc3_list="gcc32 gcc33 gcc34 gcc-3.2 gcc-3.3 gcc-3.4" Shouldn't we be preferring newer compilers? Attached patch changes order plus improves the initial GCC 4 check a bit. + echo "Looking for gcc

Re: [Qemu-devel] [PATCH] Improve gcc 3 checking

2006-12-18 Thread Paul Brook
On Tuesday 19 December 2006 02:25, Anthony Liguori wrote: > +gcc3_list="gcc32 gcc33 gcc34 gcc-3.2 gcc-3.3 gcc-3.4" Shouldn't we be preferring newer compilers? > +   echo "Looking for gcc 3.x" We shouldn't do this if if the user explicitly specified a compiler. Replacing explicit user setting

[Qemu-devel] [PATCH] Improve gcc 3 checking

2006-12-18 Thread Anthony Liguori
In Xen, we use a single top level Makefile to build everything. This means we automatically kick off the configure script. It would be nice if QEMU's configure did a better job of finding existing GCC 3.x installs so that the user didn't have to manually specific the location. The attached p