Re: [Qemu-devel] [PATCH] Improve error handling in do_snapshot_blkdev()

2011-03-03 Thread Jes Sorensen
On 03/03/11 14:06, Stefan Hajnoczi wrote: > On Thu, Mar 3, 2011 at 10:44 AM, wrote: >> +char old_filename[1024]; >> + >> +old_filename[1023] = '\0'; >> >> if (!filename) { >> qerror_report(QERR_MISSING_PARAMETER, "snapshot_file"); >> @@ -591,6 +594,10 @@ int do_snapshot_blkdev

Re: [Qemu-devel] [PATCH] Improve error handling in do_snapshot_blkdev()

2011-03-03 Thread Stefan Hajnoczi
On Thu, Mar 3, 2011 at 10:44 AM, wrote: > +    char old_filename[1024]; > + > +    old_filename[1023] = '\0'; > >     if (!filename) { >         qerror_report(QERR_MISSING_PARAMETER, "snapshot_file"); > @@ -591,6 +594,10 @@ int do_snapshot_blkdev(Monitor *mon, const QDict *qdict, > QObject **ret

[Qemu-devel] [PATCH] Improve error handling in do_snapshot_blkdev()

2011-03-03 Thread Jes . Sorensen
From: Jes Sorensen In case we cannot open the newly created snapshot image, try to fall back to the original image file and continue running on that, which should prevent the guest from aborting. This is a corner case which can happen if the admin by mistake specifies the snapshot file on a virt