Re: [Qemu-devel] [PATCH] HACKING: document #include order

2016-11-16 Thread Stefan Hajnoczi
On Wed, Nov 16, 2016 at 9:39 AM, Markus Armbruster wrote: > Eric Blake writes: > >> On 11/15/2016 02:29 PM, Stefan Hajnoczi wrote: >>> It was not obvious to me why "qemu/osdep.h" must be the first #include. >>> This documents the rationale and the overall #include order. >>> >>> Cc: Fam Zheng >>

Re: [Qemu-devel] [PATCH] HACKING: document #include order

2016-11-16 Thread Markus Armbruster
Eric Blake writes: > On 11/15/2016 02:29 PM, Stefan Hajnoczi wrote: >> It was not obvious to me why "qemu/osdep.h" must be the first #include. >> This documents the rationale and the overall #include order. >> >> Cc: Fam Zheng >> Cc: Markus Armbruster >> Cc: Eric Blake >> Signed-off-by: Stefa

Re: [Qemu-devel] [PATCH] HACKING: document #include order

2016-11-15 Thread Eric Blake
On 11/15/2016 02:29 PM, Stefan Hajnoczi wrote: > It was not obvious to me why "qemu/osdep.h" must be the first #include. > This documents the rationale and the overall #include order. > > Cc: Fam Zheng > Cc: Markus Armbruster > Cc: Eric Blake > Signed-off-by: Stefan Hajnoczi > --- > HACKING |

[Qemu-devel] [PATCH] HACKING: document #include order

2016-11-15 Thread Stefan Hajnoczi
It was not obvious to me why "qemu/osdep.h" must be the first #include. This documents the rationale and the overall #include order. Cc: Fam Zheng Cc: Markus Armbruster Cc: Eric Blake Signed-off-by: Stefan Hajnoczi --- HACKING | 15 +++ 1 file changed, 15 insertions(+) diff --git