Re: [Qemu-devel] [PATCH] Functions bus_foreach and device_find from libqos virtio API

2014-06-30 Thread Stefan Hajnoczi
On Thu, Jun 26, 2014 at 04:34:40PM +0200, Marc Marí wrote: > +static QVirtioPCIDevice *qpcidevice_to_qvirtiodevice(QPCIDevice *pdev) > +{ > +QVirtioPCIDevice *vpcidev; > +vpcidev = g_malloc0(sizeof(*vpcidev)); > + > +if (pdev) { > +vpcidev->pdev = pdev; > +vpcidev->vdev.

Re: [Qemu-devel] [PATCH] Functions bus_foreach and device_find from libqos virtio API

2014-06-26 Thread Fam Zheng
Subject better have a component prefix "[PATCH] tests: Functions bus_foreach and device_find from libqos virtio API". See also "git log tests/". Fam On Thu, 06/26 16:34, Marc Marí wrote: > Virtio header has been changed to compile and work with a real device. > Functions bus_foreach and device_

Re: [Qemu-devel] [PATCH] Functions bus_foreach and device_find from libqos virtio API

2014-06-26 Thread Paolo Bonzini
Il 26/06/2014 16:34, Marc Marí ha scritto: +static void qvirtio_pci_foreach(uint16_t device_type, +void (*func)(QVirtioDevice *d, void *data), void *data) +{ +QVirtioPCIForeachData d = { .func = func, +.device_type = device_type, +

Re: [Qemu-devel] [PATCH] Functions bus_foreach and device_find from libqos virtio API

2014-06-26 Thread Paolo Bonzini
Il 26/06/2014 17:27, Marc Marí ha scritto: If these functions are just Virtio PCI specific, it makes sense to take them out. If they are common to other transports, in my opinion is better to leave them there. Of course, a good solution has to be found to just having a global bus variable. It is

Re: [Qemu-devel] [PATCH] Functions bus_foreach and device_find from libqos virtio API

2014-06-26 Thread Marc Marí
El Thu, 26 Jun 2014 17:09:12 +0200 Paolo Bonzini escribió: > Il 26/06/2014 16:34, Marc Marí ha scritto: > > +static void qvirtio_pci_foreach(uint16_t device_type, > > +void (*func)(QVirtioDevice *d, void *data), void > > *data) +{ > > +QVirtioPCIForeachData d = { .func = func,

[Qemu-devel] [PATCH] Functions bus_foreach and device_find from libqos virtio API

2014-06-26 Thread Marc Marí
Virtio header has been changed to compile and work with a real device. Functions bus_foreach and device_find have been implemented for PCI. Virtio-blk test case now opens a fake device. Signed-off-by: Marc Marí --- tests/Makefile|3 +- tests/libqos/virtio-pci.c | 136 +++