Re: [Qemu-devel] [PATCH] Fix regressions caused by renaming README

2016-07-20 Thread Daniel P. Berrange
On Tue, Jul 19, 2016 at 09:53:30PM +0100, Peter Maydell wrote: > On 19 July 2016 at 18:47, Stefan Weil wrote: > > Commit e5dfc5e8e715c572aea44ac4d96c43941d4741c7 renamed README but did not > > update scripts/checkpatch.pl. Fix this. > > > > An update was also needed for qemu.nsi (Windows). > > > >

Re: [Qemu-devel] [PATCH] Fix regressions caused by renaming README

2016-07-20 Thread Fam Zheng
On Wed, 07/20 09:09, Paolo Bonzini wrote: > > > On 20/07/2016 09:07, Fam Zheng wrote: > >> > The question is: is anyone actually viewing formatted markdown anywhere > >> > else than on github? > > It may have slightly better syntax highlighting in editors. > > > > Out of curiosity, I'm wondering

Re: [Qemu-devel] [PATCH] Fix regressions caused by renaming README

2016-07-20 Thread Paolo Bonzini
On 20/07/2016 09:07, Fam Zheng wrote: >> > The question is: is anyone actually viewing formatted markdown anywhere >> > else than on github? > It may have slightly better syntax highlighting in editors. > > Out of curiosity, I'm wondering if it's acceptable to commit a "ln -s > README.md > READ

Re: [Qemu-devel] [PATCH] Fix regressions caused by renaming README

2016-07-20 Thread Fam Zheng
On Wed, 07/20 09:00, Paolo Bonzini wrote: > We probably want to rely on GitHub's stricter interpretation of > underscores, where they only start/end italic formatting if they are > respectively the first or the last character in the word. This is a > common extension (for example Stack Exchange do

Re: [Qemu-devel] [PATCH] Fix regressions caused by renaming README

2016-07-20 Thread Paolo Bonzini
On 20/07/2016 08:37, Markus Armbruster wrote: > I'd less unenthusiastic if MarkDown worked the same everywhere. Its > common core does, but how would we ensure we stick to the common core? > How would we even know what the core common to the various MarkDown > dialects is? README.md uses exactl

Re: [Qemu-devel] [PATCH] Fix regressions caused by renaming README

2016-07-19 Thread Markus Armbruster
Peter Maydell writes: > On 19 July 2016 at 22:17, Pranith Kumar wrote: >> On Tue, Jul 19, 2016 at 4:53 PM, Peter Maydell >> wrote: >>> Does raise the question of whether we should be renaming >>> the file in the first place. README is the traditional >>> name and fits with all our other basica

Re: [Qemu-devel] [PATCH] Fix regressions caused by renaming README

2016-07-19 Thread Peter Maydell
On 19 July 2016 at 22:17, Pranith Kumar wrote: > On Tue, Jul 19, 2016 at 4:53 PM, Peter Maydell > wrote: >> Does raise the question of whether we should be renaming >> the file in the first place. README is the traditional >> name and fits with all our other basically-plain-text >> document name

Re: [Qemu-devel] [PATCH] Fix regressions caused by renaming README

2016-07-19 Thread Peter Maydell
On 19 July 2016 at 18:47, Stefan Weil wrote: > Commit e5dfc5e8e715c572aea44ac4d96c43941d4741c7 renamed README but did not > update scripts/checkpatch.pl. Fix this. > > An update was also needed for qemu.nsi (Windows). > > Reported-by: Daniel P. Berrange > Signed-off-by: Stefan Weil > --- > qemu

Re: [Qemu-devel] [PATCH] Fix regressions caused by renaming README

2016-07-19 Thread Pranith Kumar
On Tue, Jul 19, 2016 at 4:53 PM, Peter Maydell wrote: > Does raise the question of whether we should be renaming > the file in the first place. README is the traditional > name and fits with all our other basically-plain-text > document names like COPYING, MAINTAINERS, HACKING. > I was hoping tha

Re: [Qemu-devel] [PATCH] Fix regressions caused by renaming README

2016-07-19 Thread Pranith Kumar
On Tue, Jul 19, 2016 at 1:47 PM, Stefan Weil wrote: > Commit e5dfc5e8e715c572aea44ac4d96c43941d4741c7 renamed README but did not > update scripts/checkpatch.pl. Fix this. > > An update was also needed for qemu.nsi (Windows). > > Reported-by: Daniel P. Berrange > Signed-off-by: Stefan Weil Thank

[Qemu-devel] [PATCH] Fix regressions caused by renaming README

2016-07-19 Thread Stefan Weil
Commit e5dfc5e8e715c572aea44ac4d96c43941d4741c7 renamed README but did not update scripts/checkpatch.pl. Fix this. An update was also needed for qemu.nsi (Windows). Reported-by: Daniel P. Berrange Signed-off-by: Stefan Weil --- qemu.nsi | 4 ++-- scripts/checkpatch.pl | 2 +- 2 fi