Re: [Qemu-devel] [PATCH] Fix legacy ncurses detection.

2016-11-09 Thread Samuel Thibault
Sergey Smolov, on Wed 09 Nov 2016 13:15:18 +0300, wrote: > Is it planned to publish this patch into master? Yes. Samuel

Re: [Qemu-devel] [PATCH] Fix legacy ncurses detection.

2016-11-09 Thread Sergey Smolov
On 09.11.2016 13:04, Cornelia Huck wrote: On Wed, 9 Nov 2016 10:52:38 +0100 Samuel Thibault wrote: Hello, Cornelia Huck, on Wed 09 Nov 2016 10:40:28 +0100, wrote: Still curses=no... log attached. Oops, sorry, I misplaced my code, and it somehow worked in my case. Could you give a try at th

Re: [Qemu-devel] [PATCH] Fix legacy ncurses detection.

2016-11-09 Thread Cornelia Huck
On Wed, 9 Nov 2016 10:52:38 +0100 Samuel Thibault wrote: > Hello, > > Cornelia Huck, on Wed 09 Nov 2016 10:40:28 +0100, wrote: > > Still curses=no... log attached. > > Oops, sorry, I misplaced my code, and it somehow worked in my case. > Could you give a try at the attached patch instead? Work

Re: [Qemu-devel] [PATCH] Fix legacy ncurses detection.

2016-11-09 Thread Samuel Thibault
Hello, Cornelia Huck, on Wed 09 Nov 2016 10:40:28 +0100, wrote: > Still curses=no... log attached. Oops, sorry, I misplaced my code, and it somehow worked in my case. Could you give a try at the attached patch instead? Thanks, Samuel commit cc8965eb848f53599895a650a6e062319189be1f Author: Samuel

Re: [Qemu-devel] [PATCH] Fix legacy ncurses detection.

2016-11-09 Thread Cornelia Huck
On Wed, 9 Nov 2016 10:28:35 +0100 Samuel Thibault wrote: > > cc -m64 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE > > -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings > > -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv > > -Wendif-labels -Wmissing-i

Re: [Qemu-devel] [PATCH] Fix legacy ncurses detection.

2016-11-09 Thread Samuel Thibault
Hello, Cornelia Huck, on Wed 09 Nov 2016 10:12:36 +0100, wrote: > On Wed, 9 Nov 2016 10:04:02 +0100 > Samuel Thibault wrote: > > Please post config.log so we can have a clue about what is going > > wrong. All these error messages are meant to be reported verbatim, not > > reinterpreted :) > > W

Re: [Qemu-devel] [PATCH] Fix legacy ncurses detection.

2016-11-09 Thread Cornelia Huck
On Wed, 9 Nov 2016 10:04:02 +0100 Samuel Thibault wrote: > Please post config.log so we can have a clue about what is going > wrong. All these error messages are meant to be reported verbatim, not > reinterpreted :) Well, no error here - just curses=no. config.log attached. The difference seem

Re: [Qemu-devel] [PATCH] Fix legacy ncurses detection.

2016-11-09 Thread Samuel Thibault
Hello, Cornelia Huck, on Wed 09 Nov 2016 09:58:59 +0100, wrote: > On Tue, 8 Nov 2016 21:10:19 +0100 > Samuel Thibault wrote: > > Cornelia Huck, on Tue 08 Nov 2016 12:34:49 +0100, wrote: > > “ > > configure test passed without -Werror but failed with -Werror. > > This is probably a bug in the conf

Re: [Qemu-devel] [PATCH] Fix legacy ncurses detection.

2016-11-09 Thread Cornelia Huck
On Tue, 8 Nov 2016 21:10:19 +0100 Samuel Thibault wrote: > Cornelia Huck, on Tue 08 Nov 2016 12:34:49 +0100, wrote: > > > diff --git a/configure b/configure > > > index fd6f898..e200aa8 100755 > > > --- a/configure > > > +++ b/configure > > > @@ -2926,7 +2926,7 @@ if test "$curses" != "no" ; then

Re: [Qemu-devel] [PATCH] Fix legacy ncurses detection.

2016-11-08 Thread Samuel Thibault
Cornelia Huck, on Tue 08 Nov 2016 12:34:49 +0100, wrote: > > diff --git a/configure b/configure > > index fd6f898..e200aa8 100755 > > --- a/configure > > +++ b/configure > > @@ -2926,7 +2926,7 @@ if test "$curses" != "no" ; then > > curses_inc_list="$($pkg_config --cflags ncurses 2>/dev/null):

Re: [Qemu-devel] [PATCH] Fix legacy ncurses detection.

2016-11-08 Thread Cornelia Huck
On Mon, 7 Nov 2016 23:07:41 +0100 Samuel Thibault wrote: > Hello, > > On 7 November 2016 at 13:38, Michal Suchanek wrote: > > -curses_inc_list="$($pkg_config --cflags ncursesw 2>/dev/null):" > > +curses_inc_list="$($pkg_config --cflags ncursesw > > 2>/dev/null)-I/usr/include/ncursesw:"

Re: [Qemu-devel] [PATCH] Fix legacy ncurses detection.

2016-11-07 Thread Samuel Thibault
Hello, On 7 November 2016 at 13:38, Michal Suchanek wrote: > -curses_inc_list="$($pkg_config --cflags ncursesw 2>/dev/null):" > +curses_inc_list="$($pkg_config --cflags ncursesw > 2>/dev/null)-I/usr/include/ncursesw:" Cornelia Huck, on Mon 07 Nov 2016 17:26:56 +0100, wrote: > +if [

Re: [Qemu-devel] [PATCH] Fix legacy ncurses detection.

2016-11-07 Thread Cornelia Huck
On Mon, 7 Nov 2016 13:55:29 + Peter Maydell wrote: > On 7 November 2016 at 13:38, Michal Suchanek wrote: > > ncurses version in SUSE does not have .pc files so this is still needed to > > build from git. > > > > Signed-off-by: Michal Suchanek > > --- > > configure | 2 +- > > 1 file change

Re: [Qemu-devel] [PATCH] Fix legacy ncurses detection.

2016-11-07 Thread Peter Maydell
On 7 November 2016 at 13:38, Michal Suchanek wrote: > ncurses version in SUSE does not have .pc files so this is still needed to > build from git. > > Signed-off-by: Michal Suchanek > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure >

[Qemu-devel] [PATCH] Fix legacy ncurses detection.

2016-11-07 Thread Michal Suchanek
ncurses version in SUSE does not have .pc files so this is still needed to build from git. Signed-off-by: Michal Suchanek --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index fd6f898..aab70ef 100755 --- a/configure +++ b/configure @@ -2926