On 02/22/2010 10:51 AM, Adam Litke wrote:
This patch application failed. My patch adds a cb() call in
do_balloon(), but the change in git has added the cb() call to
do_info_balloon(). That is causing qemu segfaults. Applying the
following should correct the damage. Thanks.
Fix for commit: 5c3
On Fri, 2010-02-26 at 17:26 -0300, Luiz Capitulino wrote:
> This patch fixes both. One question, though:
>
> > @@ -2332,6 +2331,7 @@ static int do_balloon(Monitor *mon, const QDict
> > *params,
> > return -1;
> > }
> >
> > +cb(opaque, NULL);
> > return 0;
> > }
>
> Ca
On Mon, 22 Feb 2010 10:51:20 -0600
Adam Litke wrote:
> On Fri, 2010-02-19 at 15:47 -0600, Anthony Liguori wrote:
> > On 02/12/2010 02:55 PM, Adam Litke wrote:
> > > Arghh... Adding missing S-O-B
> > >
> > > Hi Anthony. I wonder if there was a problem when importing my async
> > > command handler
On Fri, 2010-02-19 at 15:47 -0600, Anthony Liguori wrote:
> On 02/12/2010 02:55 PM, Adam Litke wrote:
> > Arghh... Adding missing S-O-B
> >
> > Hi Anthony. I wonder if there was a problem when importing my async
> > command handler patchset. Since the 'balloon' command completes
> > immediately,
On 02/12/2010 02:55 PM, Adam Litke wrote:
Arghh... Adding missing S-O-B
Hi Anthony. I wonder if there was a problem when importing my async
command handler patchset. Since the 'balloon' command completes
immediately, it must call the completion callback before returning.
That call was missing
On Fri, Feb 12, 2010 at 02:55:56PM -0600, Adam Litke wrote:
> Arghh... Adding missing S-O-B
>
> Hi Anthony. I wonder if there was a problem when importing my async
> command handler patchset. Since the 'balloon' command completes
> immediately, it must call the completion callback before returni
Arghh... Adding missing S-O-B
Hi Anthony. I wonder if there was a problem when importing my async
command handler patchset. Since the 'balloon' command completes
immediately, it must call the completion callback before returning.
That call was missing but is added by the patch below.
Signed-off
Hi Anthony. I wonder if there was a problem when importing my async
command handler patchset. Since the 'balloon' command completes
immediately, it must call the completion callback before returning.
That call was missing but is added by the patch below.
diff --git a/monitor.c b/monitor.c
index
