Re: [Qemu-devel] [PATCH] Fix for RSP vCont packet

2019-03-04 Thread Luc Michel
Hi Lucien, When you do a re-roll of your patch, you should: - Send it as a new thread (don't reply to an existing one) - Add the re-roll count ([PATCH vX] in the subject, easily done using the -v option of git format-patch). On 3/4/19 8:39 AM, Lucien Murray-Pitts wrote: > This fixes a regress

Re: [Qemu-devel] [PATCH] Fix for RSP vCont packet

2019-03-03 Thread Lucien Murray-Pitts via Qemu-devel
This fixes a regression in rsp packet vCont, this was due to the recently added multiprocess support. (Short commit hash: e40e520). The result is that vCont now does not recognise the case where no process/thread is provided after the action. This may not show up with GDB, but using Lauterbach Tr

Re: [Qemu-devel] [PATCH] Fix for RSP vCont packet

2019-02-05 Thread Luc Michel
Hi, On 2/1/19 3:25 PM, Lucien Anti-Spam wrote: > Hi Luc, > > Great feedback from both you and Eric - im blown away, I dont think > theres a single 1byte ascii character left unturned there :) > My coding style snuck in erywhere, as did my Scottish English! > > On Friday, February 1, 2019, 10:33:

Re: [Qemu-devel] [PATCH] Fix for RSP vCont packet

2019-02-01 Thread Lucien Anti-Spam via Qemu-devel
Hi Luc, Great feedback from both you and Eric - im blown away, I dont thinktheres a single 1byte ascii character left unturned there :)My coding style snuck in erywhere, as did my Scottish English! On Friday, February 1, 2019, 10:33:18 PM GMT+9, Luc Michel wrote: > > +    GDBThreadIdKind v

Re: [Qemu-devel] [PATCH] Fix for RSP vCont packet

2019-02-01 Thread Luc Michel
Hi Lucien, On 1/31/19 5:48 AM, Lucien Murray-Pitts wrote: > The result is that vCont now does not recognise the case where no > process/thread is provided after the action. > > This may not show up with GDB, but using Lauterbach Trace32, and Hexrays IDA > Pro this issue is immediately seen. > T

Re: [Qemu-devel] [PATCH] Fix for RSP vCont packet

2019-01-31 Thread Eric Blake
On 1/30/19 10:48 PM, Lucien Murray-Pitts wrote: > The result is that vCont now does not recognise the case where no > process/thread is provided after the action. Thanks for re-sending; this one came through a lot nicer! Welcome to the community; while a first submission can always be a bit daun

Re: [Qemu-devel] [PATCH] Fix for RSP vCont packet

2019-01-30 Thread Lucien Murray-Pitts via Qemu-devel
The result is that vCont now does not recognise the case where no process/thread is provided after the action. This may not show up with GDB, but using Lauterbach Trace32, and Hexrays IDA Pro this issue is immediately seen. The response is a "$#00" empty packet, showing it is unsupported packet.

Re: [Qemu-devel] [PATCH] Fix for RSP vCont packet

2019-01-30 Thread Lucien Anti-Spam via Qemu-devel
On Thursday, January 31, 2019, 12:47:23 PM GMT+9, Eric Blake wrote: On 1/30/19 6:41 PM, Lucien Anti-Spam via Qemu-devel wrote: > > This fixes a regression in rsp packet vCont due to recently added > > multiprocess support. (Short commit hash: e40e520). > > > Your mailer completely b

Re: [Qemu-devel] [PATCH] Fix for RSP vCont packet

2019-01-30 Thread Eric Blake
On 1/30/19 6:41 PM, Lucien Anti-Spam via Qemu-devel wrote: > This fixes a regression in rsp packet vCont due to recently added > multiprocess support. (Short commit hash: e40e520). > Your mailer completely botched the message (wrong line endings?) Can you please resend, preferably using git sen

[Qemu-devel] [PATCH] Fix for RSP vCont packet

2019-01-30 Thread Lucien Anti-Spam via Qemu-devel
This fixes a regression in rsp packet vCont due to recently added multiprocess support. (Short commit hash: e40e520). The result is that vCont now does not recognise the case where no process/thread is provided after the action. This may not show up with GDB, but using Lauterbach Trace32, and He