Re: [Qemu-devel] [PATCH] Fix emulation of splice syscall

2015-02-05 Thread Peter Maydell
On 5 February 2015 at 11:31, Andreas Schwab wrote: > The second and fourth argument are in/out parameters, store them back > after the syscall. Also, the fourth argument was mishandled, and EFAULT > handling was missing. > > Signed-off-by: Andreas Schwab Reviewed-by: Peter Maydell and cc'ing

[Qemu-devel] [PATCH] Fix emulation of splice syscall

2015-02-05 Thread Andreas Schwab
The second and fourth argument are in/out parameters, store them back after the syscall. Also, the fourth argument was mishandled, and EFAULT handling was missing. Signed-off-by: Andreas Schwab --- linux-user/syscall.c | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-

Re: [Qemu-devel] [PATCH] Fix emulation of splice syscall

2015-02-05 Thread Peter Maydell
On 5 February 2015 at 08:20, Andreas Schwab wrote: > Peter Maydell writes: > >> Coding style demands braces for all these if statements. > > That must be a recent change. It's been documented in CODING_STYLE since we first wrote down our style choices in 2009... There is of course still a fair

Re: [Qemu-devel] [PATCH] Fix emulation of splice syscall

2015-02-05 Thread Andreas Schwab
Peter Maydell writes: > Coding style demands braces for all these if statements. That must be a recent change. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: [Qemu-devel] [PATCH] Fix emulation of splice syscall

2015-02-04 Thread Peter Maydell
On 4 February 2015 at 16:37, Andreas Schwab wrote: > The second and fourth argument are in/out parameters, store them back > after the syscall. Also, the fourth argument was mishandled, and EFAULT > handling was missing. > > Signed-off-by: Andreas Schwab > --- > linux-user/syscall.c | 16 ++

[Qemu-devel] [PATCH] Fix emulation of splice syscall

2015-02-04 Thread Andreas Schwab
The second and fourth argument are in/out parameters, store them back after the syscall. Also, the fourth argument was mishandled, and EFAULT handling was missing. Signed-off-by: Andreas Schwab --- linux-user/syscall.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) dif