Re: [Qemu-devel] [PATCH] Fix curses on big endian hosts

2010-12-31 Thread Aurelien Jarno
On Sat, Jan 01, 2011 at 12:41:10AM +0100, Andreas Färber wrote: > Am 31.12.2010 um 20:10 schrieb Aurelien Jarno: > >> On Thu, Dec 30, 2010 at 05:42:43PM +, Blue Swirl wrote: >>> I'm also puzzled by the uses of TARGET_WORDS_BIGENDIAN in >>> hw/vga_template.h. I'd suppose that VGA (especially PCI

Re: [Qemu-devel] [PATCH] Fix curses on big endian hosts

2010-12-31 Thread Andreas Färber
Am 31.12.2010 um 20:10 schrieb Aurelien Jarno: On Thu, Dec 30, 2010 at 05:42:43PM +, Blue Swirl wrote: I'm also puzzled by the uses of TARGET_WORDS_BIGENDIAN in hw/vga_template.h. I'd suppose that VGA (especially PCI devices) would be always little endian, so why the checks? I also do

Re: [Qemu-devel] [PATCH] Fix curses on big endian hosts

2010-12-31 Thread Aurelien Jarno
On Thu, Dec 30, 2010 at 05:42:43PM +, Blue Swirl wrote: > On Wed, Dec 29, 2010 at 9:27 PM, Aurelien Jarno wrote: > > On big endian hosts, the curses interface is unusable: the emulated > > graphic card only displays garbage, while the monitor interface displays > > nothing (or rather only spac

Re: [Qemu-devel] [PATCH] Fix curses on big endian hosts

2010-12-30 Thread Blue Swirl
On Wed, Dec 29, 2010 at 9:27 PM, Aurelien Jarno wrote: > On big endian hosts, the curses interface is unusable: the emulated > graphic card only displays garbage, while the monitor interface displays > nothing (or rather only spaces). > > The curses interface is waiting for data in native endianne

[Qemu-devel] [PATCH] Fix curses on big endian hosts

2010-12-29 Thread Aurelien Jarno
On big endian hosts, the curses interface is unusable: the emulated graphic card only displays garbage, while the monitor interface displays nothing (or rather only spaces). The curses interface is waiting for data in native endianness, so console_write_ch() should not do any conversion. The conve