Re: [Qemu-devel] [PATCH] Fix compiler warning (always return a value)

2011-10-28 Thread Paolo Bonzini
On 10/28/2011 04:39 PM, Markus Armbruster wrote: > > I'm tempted to continue the thread but at the end of the day we just > need to make the function compile with -NDEBUG. Using abort(3) or Do we? Anyone crazy^Wadventurous enough to compile with -DNDEBUG should be capable of configure --disa

Re: [Qemu-devel] [PATCH] Fix compiler warning (always return a value)

2011-10-28 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Fri, Oct 28, 2011 at 12:07 PM, Markus Armbruster wrote: >> Stefan Hajnoczi writes: >> >>> On Fri, Oct 28, 2011 at 9:59 AM, Markus Armbruster >>> wrote: Stefan Hajnoczi writes: > On Fri, Oct 28, 2011 at 8:40 AM, Markus Armbruster > wrote: >

Re: [Qemu-devel] [PATCH] Fix compiler warning (always return a value)

2011-10-28 Thread Stefan Hajnoczi
On Fri, Oct 28, 2011 at 12:07 PM, Markus Armbruster wrote: > Stefan Hajnoczi writes: > >> On Fri, Oct 28, 2011 at 9:59 AM, Markus Armbruster wrote: >>> Stefan Hajnoczi writes: >>> On Fri, Oct 28, 2011 at 8:40 AM, Markus Armbruster wrote: > Stefan Hajnoczi writes: > >> O

Re: [Qemu-devel] [PATCH] Fix compiler warning (always return a value)

2011-10-28 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Fri, Oct 28, 2011 at 9:59 AM, Markus Armbruster wrote: >> Stefan Hajnoczi writes: >> >>> On Fri, Oct 28, 2011 at 8:40 AM, Markus Armbruster >>> wrote: Stefan Hajnoczi writes: > On Mon, Oct 24, 2011 at 10:18:43PM +0200, Stefan Weil wrote: >> For

Re: [Qemu-devel] [PATCH] Fix compiler warning (always return a value)

2011-10-28 Thread Stefan Hajnoczi
On Fri, Oct 28, 2011 at 9:59 AM, Markus Armbruster wrote: > Stefan Hajnoczi writes: > >> On Fri, Oct 28, 2011 at 8:40 AM, Markus Armbruster wrote: >>> Stefan Hajnoczi writes: >>> On Mon, Oct 24, 2011 at 10:18:43PM +0200, Stefan Weil wrote: > For compilations with -DNDEBUG, the default

Re: [Qemu-devel] [PATCH] Fix compiler warning (always return a value)

2011-10-28 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Fri, Oct 28, 2011 at 8:40 AM, Markus Armbruster wrote: >> Stefan Hajnoczi writes: >> >>> On Mon, Oct 24, 2011 at 10:18:43PM +0200, Stefan Weil wrote: For compilations with -DNDEBUG, the default case did not return a value which caused a compiler warning. >

Re: [Qemu-devel] [PATCH] Fix compiler warning (always return a value)

2011-10-28 Thread Stefan Hajnoczi
On Fri, Oct 28, 2011 at 8:40 AM, Markus Armbruster wrote: > Stefan Hajnoczi writes: > >> On Mon, Oct 24, 2011 at 10:18:43PM +0200, Stefan Weil wrote: >>> For compilations with -DNDEBUG, the default case did not return >>> a value which caused a compiler warning. >>> >>> Signed-off-by: Stefan Weil

Re: [Qemu-devel] [PATCH] Fix compiler warning (always return a value)

2011-10-28 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Mon, Oct 24, 2011 at 10:18:43PM +0200, Stefan Weil wrote: >> For compilations with -DNDEBUG, the default case did not return >> a value which caused a compiler warning. >> >> Signed-off-by: Stefan Weil >> --- >> hw/ppce500_spin.c | 11 --- >> 1 files chan

Re: [Qemu-devel] [PATCH] Fix compiler warning (always return a value), introduce qemu_abort?

2011-10-27 Thread Alexander Graf
On 26.10.2011, at 18:35, Stefan Weil wrote: > Am 26.10.2011 14:54, schrieb Stefan Hajnoczi: >> On Mon, Oct 24, 2011 at 10:18:43PM +0200, Stefan Weil wrote: >>> For compilations with -DNDEBUG, the default case did not return >>> a value which caused a compiler warning. >>> >>> Signed-off-by: Ste

Re: [Qemu-devel] [PATCH] Fix compiler warning (always return a value), introduce qemu_abort?

2011-10-27 Thread Stefan Hajnoczi
On Wed, Oct 26, 2011 at 06:35:08PM +0200, Stefan Weil wrote: > Am 26.10.2011 14:54, schrieb Stefan Hajnoczi: > >On Mon, Oct 24, 2011 at 10:18:43PM +0200, Stefan Weil wrote: > >>For compilations with -DNDEBUG, the default case did not return > >>a value which caused a compiler warning. > >> > >>Sign

Re: [Qemu-devel] [PATCH] Fix compiler warning (always return a value), introduce qemu_abort?

2011-10-26 Thread Blue Swirl
On Wed, Oct 26, 2011 at 16:35, Stefan Weil wrote: > Am 26.10.2011 14:54, schrieb Stefan Hajnoczi: >> >> On Mon, Oct 24, 2011 at 10:18:43PM +0200, Stefan Weil wrote: >>> >>> For compilations with -DNDEBUG, the default case did not return >>> a value which caused a compiler warning. >>> >>> Signed-o

Re: [Qemu-devel] [PATCH] Fix compiler warning (always return a value), introduce qemu_abort?

2011-10-26 Thread Stefan Weil
Am 26.10.2011 14:54, schrieb Stefan Hajnoczi: On Mon, Oct 24, 2011 at 10:18:43PM +0200, Stefan Weil wrote: For compilations with -DNDEBUG, the default case did not return a value which caused a compiler warning. Signed-off-by: Stefan Weil --- hw/ppce500_spin.c | 11 --- 1 files changed,

Re: [Qemu-devel] [PATCH] Fix compiler warning (always return a value)

2011-10-26 Thread Stefan Hajnoczi
On Mon, Oct 24, 2011 at 10:18:43PM +0200, Stefan Weil wrote: > For compilations with -DNDEBUG, the default case did not return > a value which caused a compiler warning. > > Signed-off-by: Stefan Weil > --- > hw/ppce500_spin.c | 11 --- > 1 files changed, 8 insertions(+), 3 deletions(-

[Qemu-devel] [PATCH] Fix compiler warning (always return a value)

2011-10-24 Thread Stefan Weil
For compilations with -DNDEBUG, the default case did not return a value which caused a compiler warning. Signed-off-by: Stefan Weil --- hw/ppce500_spin.c | 11 --- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/hw/ppce500_spin.c b/hw/ppce500_spin.c index cccd940..5b5ffe