Re: [Qemu-devel] [PATCH] Fix ast2500 protection register emulation

2018-02-24 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. N/A. Internal error while reading log file --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@freelists.org

Re: [Qemu-devel] [PATCH] Fix ast2500 protection register emulation

2018-02-22 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180220132627.4163-1-hlan...@devever.net Subject: [Qemu-devel] [PATCH] Fix ast2500 protection register emulation === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total

Re: [Qemu-devel] [PATCH] Fix ast2500 protection register emulation

2018-02-22 Thread Peter Maydell
On 20 February 2018 at 13:26, Hugo Landau wrote: > Some register blocks of the ast2500 are protected by protection key > registers which require the right magic value to be written to those > registers to allow those registers to be mutated. > > Register manuals indicate that writing the correct m

Re: [Qemu-devel] [PATCH] Fix ast2500 protection register emulation

2018-02-21 Thread Cédric Le Goater
On 02/20/2018 03:19 PM, Hugo Landau wrote: >> I also gave it a test on an OpenBMC romulus image. Looks fine, but that's >> an old custom U-Boot. Which defconfig did you use for U-Boot HEAD ? > evb-ast2500_defconfig. ok > FYI, these changes are necessary, but not sufficient to get u-boot HEAD >

Re: [Qemu-devel] [PATCH] Fix ast2500 protection register emulation

2018-02-20 Thread Andrew Jeffery
On Tue, 20 Feb 2018, at 23:56, Hugo Landau wrote: > Some register blocks of the ast2500 are protected by protection key > registers which require the right magic value to be written to those > registers to allow those registers to be mutated. > > Register manuals indicate that writing the correct

Re: [Qemu-devel] [PATCH] Fix ast2500 protection register emulation

2018-02-20 Thread Hugo Landau
> I also gave it a test on an OpenBMC romulus image. Looks fine, but that's > an old custom U-Boot. Which defconfig did you use for U-Boot HEAD ? evb-ast2500_defconfig. FYI, these changes are necessary, but not sufficient to get u-boot HEAD (or for that matter u-boot 2017.11, another version tes

Re: [Qemu-devel] [PATCH] Fix ast2500 protection register emulation

2018-02-20 Thread Cédric Le Goater
On 02/20/2018 02:26 PM, Hugo Landau wrote: > Some register blocks of the ast2500 are protected by protection key > registers which require the right magic value to be written to those > registers to allow those registers to be mutated. > > Register manuals indicate that writing the correct magic v

[Qemu-devel] [PATCH] Fix ast2500 protection register emulation

2018-02-20 Thread Hugo Landau
Some register blocks of the ast2500 are protected by protection key registers which require the right magic value to be written to those registers to allow those registers to be mutated. Register manuals indicate that writing the correct magic value to these registers should cause subsequent reads