Re: [Qemu-devel] [PATCH] Fix NaN handling in softfloat

2007-12-16 Thread Aurelien Jarno
Aurelien Jarno a écrit : >> I have looked quickly at your patch, it looks like the right approach to >> define target specific things at only one place in the file. I will get >> a closer tomorrow. >> > > Sorry I have been busy with real life stuff, and haven't looked at your > patch. I have seen

Re: [Qemu-devel] [PATCH] Fix NaN handling in softfloat

2007-11-21 Thread Aurelien Jarno
> I have looked quickly at your patch, it looks like the right approach to > define target specific things at only one place in the file. I will get > a closer tomorrow. > Sorry I have been busy with real life stuff, and haven't looked at your patch. I have seen you have committed it. I have reb

Re: [Qemu-devel] [PATCH] Fix NaN handling in softfloat

2007-11-10 Thread J. Mayer
On Sat, 2007-11-10 at 19:09 +0100, Aurelien Jarno wrote: > J. Mayer a écrit : > > On Sat, 2007-11-10 at 17:15 +0100, Aurelien Jarno wrote: > >> J. Mayer a écrit : > >>> On Sat, 2007-11-10 at 10:35 +0100, Aurelien Jarno wrote: > J. Mayer a écrit : > > On Thu, 2007-11-08 at 00:05 +0100, Aur

Re: [Qemu-devel] [PATCH] Fix NaN handling in softfloat

2007-11-10 Thread Aurelien Jarno
Thiemo Seufer a écrit : > Aurelien Jarno wrote: >> On Sat, Nov 03, 2007 at 02:06:04PM -0400, Daniel Jacobowitz wrote: >>> On Sat, Nov 03, 2007 at 06:35:48PM +0100, Aurelien Jarno wrote: Hi all, The current softfloat implementation changes qNaN into sNaN when converting between

Re: [Qemu-devel] [PATCH] Fix NaN handling in softfloat

2007-11-10 Thread Thiemo Seufer
Aurelien Jarno wrote: > On Sat, Nov 03, 2007 at 02:06:04PM -0400, Daniel Jacobowitz wrote: > > On Sat, Nov 03, 2007 at 06:35:48PM +0100, Aurelien Jarno wrote: > > > Hi all, > > > > > > The current softfloat implementation changes qNaN into sNaN when > > > converting between formats, for no reason

Re: [Qemu-devel] [PATCH] Fix NaN handling in softfloat

2007-11-10 Thread Aurelien Jarno
J. Mayer a écrit : > On Sat, 2007-11-10 at 17:15 +0100, Aurelien Jarno wrote: >> J. Mayer a écrit : >>> On Sat, 2007-11-10 at 10:35 +0100, Aurelien Jarno wrote: J. Mayer a écrit : > On Thu, 2007-11-08 at 00:05 +0100, Aurelien Jarno wrote: >> On Tue, Nov 06, 2007 at 09:01:13PM +0100, J.

Re: [Qemu-devel] [PATCH] Fix NaN handling in softfloat

2007-11-10 Thread J. Mayer
On Sat, 2007-11-10 at 17:15 +0100, Aurelien Jarno wrote: > J. Mayer a écrit : > > On Sat, 2007-11-10 at 10:35 +0100, Aurelien Jarno wrote: > >> J. Mayer a écrit : > >>> On Thu, 2007-11-08 at 00:05 +0100, Aurelien Jarno wrote: > On Tue, Nov 06, 2007 at 09:01:13PM +0100, J. Mayer wrote: > >

Re: [Qemu-devel] [PATCH] Fix NaN handling in softfloat

2007-11-10 Thread Aurelien Jarno
J. Mayer a écrit : > On Sat, 2007-11-10 at 10:35 +0100, Aurelien Jarno wrote: >> J. Mayer a écrit : >>> On Thu, 2007-11-08 at 00:05 +0100, Aurelien Jarno wrote: On Tue, Nov 06, 2007 at 09:01:13PM +0100, J. Mayer wrote: > On Sat, 2007-11-03 at 22:28 +0100, Aurelien Jarno wrote: >> On S

Re: [Qemu-devel] [PATCH] Fix NaN handling in softfloat

2007-11-10 Thread J. Mayer
On Sat, 2007-11-10 at 10:35 +0100, Aurelien Jarno wrote: > J. Mayer a écrit : > > On Thu, 2007-11-08 at 00:05 +0100, Aurelien Jarno wrote: > >> On Tue, Nov 06, 2007 at 09:01:13PM +0100, J. Mayer wrote: > >>> On Sat, 2007-11-03 at 22:28 +0100, Aurelien Jarno wrote: > On Sat, Nov 03, 2007 at 0

Re: [Qemu-devel] [PATCH] Fix NaN handling in softfloat

2007-11-10 Thread Aurelien Jarno
J. Mayer a écrit : > On Thu, 2007-11-08 at 00:05 +0100, Aurelien Jarno wrote: >> On Tue, Nov 06, 2007 at 09:01:13PM +0100, J. Mayer wrote: >>> On Sat, 2007-11-03 at 22:28 +0100, Aurelien Jarno wrote: On Sat, Nov 03, 2007 at 02:06:04PM -0400, Daniel Jacobowitz wrote: > On Sat, Nov 03, 2007

Re: [Qemu-devel] [PATCH] Fix NaN handling in softfloat

2007-11-09 Thread J. Mayer
On Thu, 2007-11-08 at 00:05 +0100, Aurelien Jarno wrote: > On Tue, Nov 06, 2007 at 09:01:13PM +0100, J. Mayer wrote: > > > > On Sat, 2007-11-03 at 22:28 +0100, Aurelien Jarno wrote: > > > On Sat, Nov 03, 2007 at 02:06:04PM -0400, Daniel Jacobowitz wrote: > > > > On Sat, Nov 03, 2007 at 06:35:48P

Re: [Qemu-devel] [PATCH] Fix NaN handling in softfloat

2007-11-07 Thread Thiemo Seufer
Daniel Jacobowitz wrote: > On Thu, Nov 08, 2007 at 12:05:25AM +0100, Aurelien Jarno wrote: > > Has Thiemo already said, there is no IEEE behavior. If you look at the > > IEEE 754 document you will see that it has requirements on what should > > be supported by an IEEE compliant FPU, but has very fe

Re: [Qemu-devel] [PATCH] Fix NaN handling in softfloat

2007-11-07 Thread Daniel Jacobowitz
On Thu, Nov 08, 2007 at 12:05:25AM +0100, Aurelien Jarno wrote: > Has Thiemo already said, there is no IEEE behavior. If you look at the > IEEE 754 document you will see that it has requirements on what should > be supported by an IEEE compliant FPU, but has very few requirements on > the implement

Re: [Qemu-devel] [PATCH] Fix NaN handling in softfloat

2007-11-07 Thread Aurelien Jarno
On Tue, Nov 06, 2007 at 09:01:13PM +0100, J. Mayer wrote: > > On Sat, 2007-11-03 at 22:28 +0100, Aurelien Jarno wrote: > > On Sat, Nov 03, 2007 at 02:06:04PM -0400, Daniel Jacobowitz wrote: > > > On Sat, Nov 03, 2007 at 06:35:48PM +0100, Aurelien Jarno wrote: > > > > Hi all, > > > > > > > > The

Re: [Qemu-devel] [PATCH] Fix NaN handling in softfloat

2007-11-06 Thread Thiemo Seufer
J. Mayer wrote: > > On Sat, 2007-11-03 at 22:28 +0100, Aurelien Jarno wrote: > > On Sat, Nov 03, 2007 at 02:06:04PM -0400, Daniel Jacobowitz wrote: > > > On Sat, Nov 03, 2007 at 06:35:48PM +0100, Aurelien Jarno wrote: > > > > Hi all, > > > > > > > > The current softfloat implementation changes q

Re: [Qemu-devel] [PATCH] Fix NaN handling in softfloat

2007-11-06 Thread J. Mayer
On Sat, 2007-11-03 at 22:28 +0100, Aurelien Jarno wrote: > On Sat, Nov 03, 2007 at 02:06:04PM -0400, Daniel Jacobowitz wrote: > > On Sat, Nov 03, 2007 at 06:35:48PM +0100, Aurelien Jarno wrote: > > > Hi all, > > > > > > The current softfloat implementation changes qNaN into sNaN when > > > conv

Re: [Qemu-devel] [PATCH] Fix NaN handling in softfloat

2007-11-03 Thread Aurelien Jarno
On Sat, Nov 03, 2007 at 02:06:04PM -0400, Daniel Jacobowitz wrote: > On Sat, Nov 03, 2007 at 06:35:48PM +0100, Aurelien Jarno wrote: > > Hi all, > > > > The current softfloat implementation changes qNaN into sNaN when > > converting between formats, for no reason. The attached patch fixes > > tha

Re: [Qemu-devel] [PATCH] Fix NaN handling in softfloat

2007-11-03 Thread Aurelien Jarno
Daniel Jacobowitz a écrit : > On Sat, Nov 03, 2007 at 06:35:48PM +0100, Aurelien Jarno wrote: >> Hi all, >> >> The current softfloat implementation changes qNaN into sNaN when >> converting between formats, for no reason. The attached patch fixes >> that. It also fixes an off-by-one in the extende

Re: [Qemu-devel] [PATCH] Fix NaN handling in softfloat

2007-11-03 Thread Aurelien Jarno
Thiemo Seufer a écrit : > Aurelien Jarno wrote: >> Hi all, >> >> The current softfloat implementation changes qNaN into sNaN when >> converting between formats, for no reason. The attached patch fixes >> that. > > Did you take into account that MIPS and PA-RISC have the signalling > bit inverted

Re: [Qemu-devel] [PATCH] Fix NaN handling in softfloat

2007-11-03 Thread Thiemo Seufer
Aurelien Jarno wrote: > Hi all, > > The current softfloat implementation changes qNaN into sNaN when > converting between formats, for no reason. The attached patch fixes > that. Did you take into account that MIPS and PA-RISC have the signalling bit inverted to the rest of the world? > It also

Re: [Qemu-devel] [PATCH] Fix NaN handling in softfloat

2007-11-03 Thread Daniel Jacobowitz
On Sat, Nov 03, 2007 at 06:35:48PM +0100, Aurelien Jarno wrote: > Hi all, > > The current softfloat implementation changes qNaN into sNaN when > converting between formats, for no reason. The attached patch fixes > that. It also fixes an off-by-one in the extended double precision > format (aka f

[Qemu-devel] [PATCH] Fix NaN handling in softfloat

2007-11-03 Thread Aurelien Jarno
Hi all, The current softfloat implementation changes qNaN into sNaN when converting between formats, for no reason. The attached patch fixes that. It also fixes an off-by-one in the extended double precision format (aka floatx80), the mantissa is 64-bit long and not 63-bit long. With this patch