Re: [Qemu-devel] [PATCH] Fix NBD unsupported options

2016-04-06 Thread Alex Bligh
On 6 Apr 2016, at 17:14, Eric Blake wrote: > I just re-reviewed this patch. While what you have is a strict > improvement, it is still buggy for a server that sends a UTF-8 message > explaining the error: Indeed. That should be fixed too. I missed that one. -- Alex Bligh signature.asc De

Re: [Qemu-devel] [PATCH] Fix NBD unsupported options

2016-04-06 Thread Eric Blake
On 04/05/2016 12:55 PM, Alex Bligh wrote: > nbd-client.c currently fails to handle unsupported options properly. > If during option haggling the server finds an option that is > unsupported, it returns an NBD_REP_ERR_UNSUP reply. > > According to nbd's proto.md, the format for such a reply > shoul

Re: [Qemu-devel] [PATCH] Fix NBD unsupported options

2016-04-06 Thread Paolo Bonzini
On 05/04/2016 20:55, Alex Bligh wrote: > nbd-client.c currently fails to handle unsupported options properly. > If during option haggling the server finds an option that is > unsupported, it returns an NBD_REP_ERR_UNSUP reply. > > According to nbd's proto.md, the format for such a reply > should

[Qemu-devel] [PATCH] Fix NBD unsupported options

2016-04-05 Thread Alex Bligh
nbd-client.c currently fails to handle unsupported options properly. If during option haggling the server finds an option that is unsupported, it returns an NBD_REP_ERR_UNSUP reply. According to nbd's proto.md, the format for such a reply should be: S: 64 bits, 0x3e889045565a9 (magic number for