Re: [Qemu-devel] [PATCH] Fix -snapshot deleting images on disk change

2010-07-26 Thread Kevin Wolf
Am 25.07.2010 22:49, schrieb Blue Swirl: > Block device change command did not copy BDRV_O_SNAPSHOT flag. Thus > the new image did not have this flag and the file got deleted during > opening. > > Fix by copying BDRV_O_SNAPSHOT flag. > > Signed-off-by: Blue Swirl Thanks, applied to the block br

Re: [Qemu-devel] [PATCH] Fix -snapshot deleting images on disk change

2010-07-25 Thread Markus Armbruster
Blue Swirl writes: > Block device change command did not copy BDRV_O_SNAPSHOT flag. Thus > the new image did not have this flag and the file got deleted during > opening. > > Fix by copying BDRV_O_SNAPSHOT flag. Aha: the file gets deleted because bs->is_temporary survives change, but BDRV_O_SNAP

[Qemu-devel] [PATCH] Fix -snapshot deleting images on disk change

2010-07-25 Thread Blue Swirl
Block device change command did not copy BDRV_O_SNAPSHOT flag. Thus the new image did not have this flag and the file got deleted during opening. Fix by copying BDRV_O_SNAPSHOT flag. Signed-off-by: Blue Swirl --- block.c|5 + block.h|1 + blockdev.c |1 + 3 files changed