On Thu, Sep 20, 2018 at 07:08:32AM -0400, Mao Zhongyi wrote:
> error_report and friends already add a "qemu-system-xxx" prefix
> to the string, so a "qemu:" prefix is redundant in the string.
> Just drop it.
>
> Reported-by: Thomas Huth
> Signed-off-by: Mao Zhongyi
ppc parts
Acked-by: David Gib
On 9/20/18 1:34 PM, Eduardo Habkost wrote:
On Thu, Sep 20, 2018 at 07:08:32AM -0400, Mao Zhongyi wrote:
error_report and friends already add a "qemu-system-xxx" prefix
to the string, so a "qemu:" prefix is redundant in the string.
Just drop it.
Reported-by: Thomas Huth
Signed-off-by: Mao Zh
On 9/20/18 1:39 PM, Peter Maydell wrote:
if (flags & 0x0004) { /* MULTIBOOT_HEADER_HAS_VBE */
-error_report("qemu: multiboot knows VBE. we don't.");
+error_report("multiboot knows VBE. we don't.");
Since this one is intended to be a user-facing error message
rather t
Eduardo Habkost writes:
> On Thu, Sep 20, 2018 at 07:08:32AM -0400, Mao Zhongyi wrote:
>> error_report and friends already add a "qemu-system-xxx" prefix
>> to the string, so a "qemu:" prefix is redundant in the string.
>> Just drop it.
>>
>> Reported-by: Thomas Huth
>> Signed-off-by: Mao Zhong
On 20 September 2018 at 10:34, Eduardo Habkost wrote:
> On Thu, Sep 20, 2018 at 07:08:32AM -0400, Mao Zhongyi wrote:
>> error_report and friends already add a "qemu-system-xxx" prefix
>> to the string, so a "qemu:" prefix is redundant in the string.
>> Just drop it.
>>
>> Reported-by: Thomas Huth
On Thu, Sep 20, 2018 at 07:08:32AM -0400, Mao Zhongyi wrote:
> error_report and friends already add a "qemu-system-xxx" prefix
> to the string, so a "qemu:" prefix is redundant in the string.
> Just drop it.
>
> Reported-by: Thomas Huth
> Signed-off-by: Mao Zhongyi
Reviewed-by: Eduardo Habkost
error_report and friends already add a "qemu-system-xxx" prefix
to the string, so a "qemu:" prefix is redundant in the string.
Just drop it.
Reported-by: Thomas Huth
Signed-off-by: Mao Zhongyi
---
hw/i386/multiboot.c | 8
hw/ppc/e500.c | 4 ++--
hw/ppc/sam460ex.c | 8