Re: [Qemu-devel] [PATCH] Drop superfluous conditionals around g_strdup()

2014-12-04 Thread Eric Blake
On 12/04/2014 02:26 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > backends/rng-random.c| 6 +- > hw/tpm/tpm_passthrough.c | 4 +--- > util/uri.c | 43 +-- > 3 files changed, 19 insertions(+), 34 deletions(-)

Re: [Qemu-devel] [PATCH] Drop superfluous conditionals around g_strdup()

2014-12-04 Thread Eric Blake
On 12/04/2014 03:39 AM, Markus Armbruster wrote: > As per standard operating procedure, I expanded tabs in the lines I > touched. No visual difference, except in patches. > > What do you want me to do? > > 1. Don't expand tabs, ignore checkpatch.pl whining > > 2. Expand tabs in touched lines (

Re: [Qemu-devel] [PATCH] Drop superfluous conditionals around g_strdup()

2014-12-04 Thread Markus Armbruster
Fam Zheng writes: > On Thu, 12/04 11:39, Markus Armbruster wrote: >> Fam Zheng writes: >> >> > On Thu, 12/04 10:26, Markus Armbruster wrote: >> >> Signed-off-by: Markus Armbruster >> >> --- >> >> backends/rng-random.c| 6 +- >> >> hw/tpm/tpm_passthrough.c | 4 +--- >> >> util/uri.c

Re: [Qemu-devel] [PATCH] Drop superfluous conditionals around g_strdup()

2014-12-04 Thread Fam Zheng
On Thu, 12/04 11:39, Markus Armbruster wrote: > Fam Zheng writes: > > > On Thu, 12/04 10:26, Markus Armbruster wrote: > >> Signed-off-by: Markus Armbruster > >> --- > >> backends/rng-random.c| 6 +- > >> hw/tpm/tpm_passthrough.c | 4 +--- > >> util/uri.c | 43 +++

Re: [Qemu-devel] [PATCH] Drop superfluous conditionals around g_strdup()

2014-12-04 Thread Markus Armbruster
Fam Zheng writes: > On Thu, 12/04 10:26, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster >> --- >> backends/rng-random.c| 6 +- >> hw/tpm/tpm_passthrough.c | 4 +--- >> util/uri.c | 43 +-- >> 3 files changed, 19 inser

Re: [Qemu-devel] [PATCH] Drop superfluous conditionals around g_strdup()

2014-12-04 Thread Fam Zheng
On Thu, 12/04 10:26, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > backends/rng-random.c| 6 +- > hw/tpm/tpm_passthrough.c | 4 +--- > util/uri.c | 43 +-- > 3 files changed, 19 insertions(+), 34 deletions(-) >

[Qemu-devel] [PATCH] Drop superfluous conditionals around g_strdup()

2014-12-04 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- backends/rng-random.c| 6 +- hw/tpm/tpm_passthrough.c | 4 +--- util/uri.c | 43 +-- 3 files changed, 19 insertions(+), 34 deletions(-) diff --git a/backends/rng-random.c b/backends/rng-random.c