Re: [Qemu-devel] [PATCH] Drop braces around single statement rule

2010-08-02 Thread Anthony Liguori
On 08/02/2010 11:29 AM, Blue Swirl wrote: Yeah, I'm neglecting the fact that we're not consistent as maintainers and I'm all for dropping it from CODING_STYLE. I'd rather expand the document. For example, I like the approach libvirt takes: http://libvirt.org/git/?p=libvirt.git;a=blob_plain

Re: [Qemu-devel] [PATCH] Drop braces around single statement rule

2010-08-02 Thread Blue Swirl
On Mon, Aug 2, 2010 at 4:18 PM, Anthony Liguori wrote: > On 08/02/2010 11:06 AM, malc wrote: >> >> On Mon, 2 Aug 2010, Anthony Liguori wrote: >> >> >>> >>> On 08/02/2010 10:41 AM, Kevin Wolf wrote: >>> > > But something like braces around an if doesn't seem like it creates a

Re: [Qemu-devel] [PATCH] Drop braces around single statement rule

2010-08-02 Thread Anthony Liguori
On 08/02/2010 11:06 AM, malc wrote: On Mon, 2 Aug 2010, Anthony Liguori wrote: On 08/02/2010 10:41 AM, Kevin Wolf wrote: But something like braces around an if doesn't seem like it creates a big problem. Most C programmers are used to seeing braces in some statements and not

Re: [Qemu-devel] [PATCH] Drop braces around single statement rule

2010-08-02 Thread Blue Swirl
On Mon, Aug 2, 2010 at 3:20 PM, Anthony Liguori wrote: > On 07/31/2010 06:49 PM, Aurelien Jarno wrote: >> >> On Sat, Jul 31, 2010 at 08:23:55PM +, Blue Swirl wrote: >> >>> >>> On Sat, Jul 31, 2010 at 4:23 PM, malc  wrote: >>> History has shown that this particular rule is unenforcabl

Re: [Qemu-devel] [PATCH] Drop braces around single statement rule

2010-08-02 Thread malc
On Mon, 2 Aug 2010, Anthony Liguori wrote: > On 08/02/2010 10:41 AM, Kevin Wolf wrote: > > > > > But something like braces around an if doesn't seem like it creates a > > > big problem. Most C programmers are used to seeing braces in some > > > statements and not other. Therefore, it's hard to

Re: [Qemu-devel] [PATCH] Drop braces around single statement rule

2010-08-02 Thread Anthony Liguori
On 08/02/2010 10:55 AM, malc wrote: Rejecting a big patch because braces aren't used in single line if statements seems to be an unnecessary barrier to me. Taking such patches anyway is basically what we're doing today, right? And what malc is complaining about. Malc is mainly com

Re: [Qemu-devel] [PATCH] Drop braces around single statement rule

2010-08-02 Thread malc
On Mon, 2 Aug 2010, Kevin Wolf wrote: > Am 02.08.2010 17:20, schrieb Anthony Liguori: > > On 07/31/2010 06:49 PM, Aurelien Jarno wrote: > >> On Sat, Jul 31, 2010 at 08:23:55PM +, Blue Swirl wrote: [..snip..] > > > So really, I think the problem is that we're enforcing the words of > > CODIN

Re: [Qemu-devel] [PATCH] Drop braces around single statement rule

2010-08-02 Thread Anthony Liguori
On 08/02/2010 10:41 AM, Kevin Wolf wrote: But something like braces around an if doesn't seem like it creates a big problem. Most C programmers are used to seeing braces in some statements and not other. Therefore, it's hard to argue that the code gets really unreadable if this isn't strictly

Re: [Qemu-devel] [PATCH] Drop braces around single statement rule

2010-08-02 Thread Kevin Wolf
Am 02.08.2010 17:20, schrieb Anthony Liguori: > On 07/31/2010 06:49 PM, Aurelien Jarno wrote: >> On Sat, Jul 31, 2010 at 08:23:55PM +, Blue Swirl wrote: >> >>> On Sat, Jul 31, 2010 at 4:23 PM, malc wrote: >>> History has shown that this particular rule is unenforcable.

Re: [Qemu-devel] [PATCH] Drop braces around single statement rule

2010-08-02 Thread Anthony Liguori
On 07/31/2010 06:49 PM, Aurelien Jarno wrote: On Sat, Jul 31, 2010 at 08:23:55PM +, Blue Swirl wrote: On Sat, Jul 31, 2010 at 4:23 PM, malc wrote: History has shown that this particular rule is unenforcable. Signed-off-by: malc --- CODING_STYLE | 11 ++- 1 files cha

Re: [Qemu-devel] [PATCH] Drop braces around single statement rule

2010-07-31 Thread Aurelien Jarno
On Sat, Jul 31, 2010 at 08:23:55PM +, Blue Swirl wrote: > On Sat, Jul 31, 2010 at 4:23 PM, malc wrote: > > History has shown that this particular rule is unenforcable. > > > > Signed-off-by: malc > > --- > >  CODING_STYLE |   11 ++- > >  1 files changed, 6 insertions(+), 5 deletions(-

Re: [Qemu-devel] [PATCH] Drop braces around single statement rule

2010-07-31 Thread malc
On Sat, 31 Jul 2010, Blue Swirl wrote: > On Sat, Jul 31, 2010 at 4:23 PM, malc wrote: > > History has shown that this particular rule is unenforcable. > > > > Signed-off-by: malc > > --- > >  CODING_STYLE |   11 ++- > >  1 files changed, 6 insertions(+), 5 deletions(-) > > Not again: >

Re: [Qemu-devel] [PATCH] Drop braces around single statement rule

2010-07-31 Thread Blue Swirl
On Sat, Jul 31, 2010 at 4:23 PM, malc wrote: > History has shown that this particular rule is unenforcable. > > Signed-off-by: malc > --- >  CODING_STYLE |   11 ++- >  1 files changed, 6 insertions(+), 5 deletions(-) Not again: http://lists.nongnu.org/archive/html/qemu-devel/2009-12/msg0

Re: [Qemu-devel] [PATCH] Drop braces around single statement rule

2010-07-31 Thread Aurelien Jarno
On Sat, Jul 31, 2010 at 06:47:29PM +0200, Aurelien Jarno wrote: > On Sat, Jul 31, 2010 at 08:23:34PM +0400, malc wrote: > > History has shown that this particular rule is unenforcable. > > > > Signed-off-by: malc > > --- > > CODING_STYLE | 11 ++- > > 1 files changed, 6 insertions(+),

Re: [Qemu-devel] [PATCH] Drop braces around single statement rule

2010-07-31 Thread Aurelien Jarno
On Sat, Jul 31, 2010 at 08:23:34PM +0400, malc wrote: > History has shown that this particular rule is unenforcable. > > Signed-off-by: malc > --- > CODING_STYLE | 11 ++- > 1 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/CODING_STYLE b/CODING_STYLE > index 92036f3..

[Qemu-devel] [PATCH] Drop braces around single statement rule

2010-07-31 Thread malc
History has shown that this particular rule is unenforcable. Signed-off-by: malc --- CODING_STYLE | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/CODING_STYLE b/CODING_STYLE index 92036f3..e0b5376 100644 --- a/CODING_STYLE +++ b/CODING_STYLE @@ -54,16 +54,17 @@