On 31 January 2017 at 16:14, Peter Maydell wrote:
> We already require gcc 4.1 or newer (for the atomic
> support), so the fallback codepaths for older gcc
> versions than that are now dead code and we can
> just delete them.
>
> NB: clang reports itself as gcc 4.2 (regardless of
> clang version),
Paolo Bonzini writes:
> On 31/01/2017 22:49, Markus Armbruster wrote:
>> Paolo Bonzini writes:
>>
>>> On 31/01/2017 12:40, Markus Armbruster wrote:
>
> #define QEMU_NORETURN __attribute__ ((__noreturn__))
>
> -#if QEMU_GNUC_PREREQ(3, 4)
> #define QEMU_WARN_UNUSED_RESUL
On 31/01/2017 22:49, Markus Armbruster wrote:
> Paolo Bonzini writes:
>
>> On 31/01/2017 12:40, Markus Armbruster wrote:
#define QEMU_NORETURN __attribute__ ((__noreturn__))
-#if QEMU_GNUC_PREREQ(3, 4)
#define QEMU_WARN_UNUSED_RESULT __attribute__((warn_unused_res
Paolo Bonzini writes:
> On 31/01/2017 12:40, Markus Armbruster wrote:
>>>
>>> #define QEMU_NORETURN __attribute__ ((__noreturn__))
>>>
>>> -#if QEMU_GNUC_PREREQ(3, 4)
>>> #define QEMU_WARN_UNUSED_RESULT __attribute__((warn_unused_result))
>>> -#else
>>> -#define QEMU_WARN_UNUSED_RESULT
>>>
On 31/01/2017 11:58, Peter Maydell wrote:
> On 31 January 2017 at 16:55, Daniel P. Berrange wrote:
>> On Tue, Jan 31, 2017 at 04:14:47PM +, Peter Maydell wrote:
>>> We already require gcc 4.1 or newer (for the atomic
>>> support), so the fallback codepaths for older gcc
>>> versions than tha
On 31/01/2017 12:40, Markus Armbruster wrote:
>>
>> #define QEMU_NORETURN __attribute__ ((__noreturn__))
>>
>> -#if QEMU_GNUC_PREREQ(3, 4)
>> #define QEMU_WARN_UNUSED_RESULT __attribute__((warn_unused_result))
>> -#else
>> -#define QEMU_WARN_UNUSED_RESULT
>> -#endif
> Should we inline this
Peter Maydell writes:
> On 31 January 2017 at 18:11, Daniel P. Berrange wrote:
>> On Tue, Jan 31, 2017 at 06:00:13PM +, Peter Maydell wrote:
>>> We have attributes which we wrap in QEMU_ macros already
>>> even though they always expand to the same thing:
>>> QEMU_NORETURN and QEMU_ALIGNED.
Peter Maydell writes:
> On 31 January 2017 at 17:40, Markus Armbruster wrote:
>> Peter Maydell writes:
>>
>>> We already require gcc 4.1 or newer (for the atomic
>>> support), so the fallback codepaths for older gcc
>>> versions than that are now dead code and we can
>>> just delete them.
>>>
>
On Tue, Jan 31, 2017 at 06:00:13PM +, Peter Maydell wrote:
> On 31 January 2017 at 17:40, Markus Armbruster wrote:
> > Peter Maydell writes:
> >
> >> We already require gcc 4.1 or newer (for the atomic
> >> support), so the fallback codepaths for older gcc
> >> versions than that are now dead
On 31 January 2017 at 18:11, Daniel P. Berrange wrote:
> On Tue, Jan 31, 2017 at 06:00:13PM +, Peter Maydell wrote:
>> We have attributes which we wrap in QEMU_ macros already
>> even though they always expand to the same thing:
>> QEMU_NORETURN and QEMU_ALIGNED. I'm happy to leave these
>> to
On 31 January 2017 at 16:55, Daniel P. Berrange wrote:
> On Tue, Jan 31, 2017 at 04:14:47PM +, Peter Maydell wrote:
>> We already require gcc 4.1 or newer (for the atomic
>> support), so the fallback codepaths for older gcc
>> versions than that are now dead code and we can
>> just delete them
Peter Maydell writes:
> We already require gcc 4.1 or newer (for the atomic
> support), so the fallback codepaths for older gcc
> versions than that are now dead code and we can
> just delete them.
>
> NB: clang reports itself as gcc 4.2 (regardless of
> clang version), so clang won't be using th
On Tue, Jan 31, 2017 at 04:14:47PM +, Peter Maydell wrote:
> We already require gcc 4.1 or newer (for the atomic
> support), so the fallback codepaths for older gcc
> versions than that are now dead code and we can
> just delete them.
Do we have any explicit check alreadu for 4.1, or do we
jus
On 31 January 2017 at 17:40, Markus Armbruster wrote:
> Peter Maydell writes:
>
>> We already require gcc 4.1 or newer (for the atomic
>> support), so the fallback codepaths for older gcc
>> versions than that are now dead code and we can
>> just delete them.
>>
>> NB: clang reports itself as gcc
We already require gcc 4.1 or newer (for the atomic
support), so the fallback codepaths for older gcc
versions than that are now dead code and we can
just delete them.
NB: clang reports itself as gcc 4.2 (regardless of
clang version), so clang won't be using the fallbacks
either.
Signed-off-by: P
15 matches
Mail list logo