Re: [Qemu-devel] [PATCH] Don't enable a HPET timer if HPET is disabled

2014-03-27 Thread Michael S. Tsirkin
On Fri, Feb 21, 2014 at 09:37:23PM -0700, Matt Lupfer wrote: > A HPET timer can be started when HPET is not yet > enabled. This will not generate an interrupt > to the guest, but causes problems when HPET is later > enabled. > > A timer that is created and expires at least once before > HPET is en

Re: [Qemu-devel] [PATCH] Don't enable a HPET timer if HPET is disabled

2014-03-27 Thread Paolo Bonzini
Il 26/03/2014 21:20, Matt Lupfer ha scritto: On 02/22/2014 02:01 AM, Paolo Bonzini wrote: Il 22/02/2014 05:37, Matt Lupfer ha scritto: A HPET timer can be started when HPET is not yet enabled. This will not generate an interrupt to the guest, but causes problems when HPET is later enabled. A t

Re: [Qemu-devel] [PATCH] Don't enable a HPET timer if HPET is disabled

2014-03-26 Thread Matt Lupfer
On 02/22/2014 02:01 AM, Paolo Bonzini wrote: > Il 22/02/2014 05:37, Matt Lupfer ha scritto: >> A HPET timer can be started when HPET is not yet >> enabled. This will not generate an interrupt >> to the guest, but causes problems when HPET is later >> enabled. >> >> A timer that is created and expir

Re: [Qemu-devel] [PATCH] Don't enable a HPET timer if HPET is disabled

2014-02-22 Thread Paolo Bonzini
Il 22/02/2014 13:25, Alex Bligh ha scritto: Paolo, On 22 Feb 2014, at 10:55, Paolo Bonzini wrote: Il 22/02/2014 10:03, Alex Bligh ha scritto: I am unfamiliar with the HPET code but symmetry suggests perhaps the 'else' condition should be changed too: } else if (deactivating_bit(ol

Re: [Qemu-devel] [PATCH] Don't enable a HPET timer if HPET is disabled

2014-02-22 Thread Alex Bligh
Paolo, On 22 Feb 2014, at 10:55, Paolo Bonzini wrote: > Il 22/02/2014 10:03, Alex Bligh ha scritto: >> I am unfamiliar with the HPET code but symmetry suggests perhaps the 'else' >> condition should be changed too: >> >>} else if (deactivating_bit(old_val, new_val, HPET_TN_ENABLE) ||

Re: [Qemu-devel] [PATCH] Don't enable a HPET timer if HPET is disabled

2014-02-22 Thread Paolo Bonzini
Il 22/02/2014 10:03, Alex Bligh ha scritto: > I am unfamiliar with the HPET code but symmetry suggests perhaps the 'else' > condition should be changed too: > > } else if (deactivating_bit(old_val, new_val, HPET_TN_ENABLE) || >!hpet_enabled(s)) { >

Re: [Qemu-devel] [PATCH] Don't enable a HPET timer if HPET is disabled

2014-02-22 Thread Alex Bligh
On 22 Feb 2014, at 04:37, Matt Lupfer wrote: > A HPET timer can be started when HPET is not yet > enabled. This will not generate an interrupt > to the guest, but causes problems when HPET is later > enabled. > > A timer that is created and expires at least once before > HPET is enabled will hav

Re: [Qemu-devel] [PATCH] Don't enable a HPET timer if HPET is disabled

2014-02-22 Thread Paolo Bonzini
Il 22/02/2014 05:37, Matt Lupfer ha scritto: A HPET timer can be started when HPET is not yet enabled. This will not generate an interrupt to the guest, but causes problems when HPET is later enabled. A timer that is created and expires at least once before HPET is enabled will have an initializ

[Qemu-devel] [PATCH] Don't enable a HPET timer if HPET is disabled

2014-02-21 Thread Matt Lupfer
A HPET timer can be started when HPET is not yet enabled. This will not generate an interrupt to the guest, but causes problems when HPET is later enabled. A timer that is created and expires at least once before HPET is enabled will have an initialized comparator based on a hpet_offset of 0 (unin