Re: [Qemu-devel] [PATCH] Dead code removal: removing code for unsupported DEPTH.

2017-03-29 Thread Iwona Kotlarska
Hi, I wanted to say that I think this patch is beyond me, I tried working on it having considered the additional feedback, but it needs a bit more understanding of the code and I won't make it on time (I wanted to apply to Outreachy internships), so I'm very sorry for bothering you without rea

Re: [Qemu-devel] [PATCH] Dead code removal: removing code for unsupported DEPTH.

2017-03-26 Thread Gerd Hoffmann
Hi, > Also worth pointing at an example of a patchset that does > this for some other device, eg Gerd's recent pl110 set, > as a guide to what's getting removed. that was sm501 ;) https://patchwork.ozlabs.org/patch/735753/ https://patchwork.ozlabs.org/patch/735764/ cheers, Gerd

Re: [Qemu-devel] [PATCH] Dead code removal: removing code for unsupported DEPTH.

2017-03-26 Thread Gerd Hoffmann
Hi, > Some emulated graphics cards use qemu_console_surface() and that > surface is always in 32 bits per pixel format. Therefore, code for > dealing with other pixel formats can be removed. qemu_create_displaysurface() creates a displaysurface with the default depth 32bpp. qemu_console_resiz

Re: [Qemu-devel] [PATCH] Dead code removal: removing code for unsupported DEPTH.

2017-03-24 Thread Peter Maydell
On 24 March 2017 at 13:36, Stefan Hajnoczi wrote: > Gerd, please reply if this is wrong, but here is a summary of the task: > > Some emulated graphics cards use qemu_console_surface() and that > surface is always in 32 bits per pixel format. Therefore, code for > dealing with other pixel formats

Re: [Qemu-devel] [PATCH] Dead code removal: removing code for unsupported DEPTH.

2017-03-24 Thread Stefan Hajnoczi
On Thu, Mar 16, 2017 at 2:12 PM, Gerd Hoffmann wrote: >> > -#define DEPTH 8 >> > -#include "cirrus_vga_rop2.h" >> > - >> > -#define DEPTH 16 >> > -#include "cirrus_vga_rop2.h" >> > - >> > -#define DEPTH 24 >> > -#include "cirrus_vga_rop2.h" >> > - >> > #define DEPTH 32 >> > #include "cirrus_vga_

Re: [Qemu-devel] [PATCH] Dead code removal: removing code for unsupported DEPTH.

2017-03-16 Thread Paolo Bonzini
On 16/03/2017 15:12, Gerd Hoffmann wrote: > Hi, > >>> -#define DEPTH 8 >>> -#include "cirrus_vga_rop2.h" >>> - >>> -#define DEPTH 16 >>> -#include "cirrus_vga_rop2.h" >>> - >>> -#define DEPTH 24 >>> -#include "cirrus_vga_rop2.h" >>> - >>> #define DEPTH 32 >>> #include "cirrus_vga_rop2.h" >

Re: [Qemu-devel] [PATCH] Dead code removal: removing code for unsupported DEPTH.

2017-03-16 Thread Gerd Hoffmann
Hi, > > -#define DEPTH 8 > > -#include "cirrus_vga_rop2.h" > > - > > -#define DEPTH 16 > > -#include "cirrus_vga_rop2.h" > > - > > -#define DEPTH 24 > > -#include "cirrus_vga_rop2.h" > > - > > #define DEPTH 32 > > #include "cirrus_vga_rop2.h" No. It isn't *that* simple. The cirrus blitter o

Re: [Qemu-devel] [PATCH] Dead code removal: removing code for unsupported DEPTH.

2017-03-16 Thread Peter Maydell
On 16 March 2017 at 12:01, wrote: > From: Iwona Kotlarska > > Signed-off-by: Iwona Kotlarska Thanks -- cc'ing Gerd who's just done some cirrus patches and is probably best placed to review this. PS: if you put "cirrus_vga:" in your patch subject then it helps people to know what part of QEMU

[Qemu-devel] [PATCH] Dead code removal: removing code for unsupported DEPTH.

2017-03-16 Thread iwona260909
From: Iwona Kotlarska Signed-off-by: Iwona Kotlarska --- hw/display/cirrus_vga.c | 3 --- hw/display/cirrus_vga_rop.h | 9 - hw/display/cirrus_vga_rop2.h | 46 ++-- 3 files changed, 2 insertions(+), 56 deletions(-) diff --git a/hw/display

[Qemu-devel] [PATCH] Dead code removal: removing code for unsupported DEPTH.

2017-03-16 Thread iwona260909
Removing code for unsupproted DEPTH. This time I looked for it in mailing list archive and haven't found, hope it wasn't done.