Re: [Qemu-devel] [PATCH] Correct and standardize header guards in all header files

2011-06-06 Thread Stefan Hajnoczi
On Sun, Jun 5, 2011 at 4:57 AM, Alexandre Raymond wrote: > diff --git a/balloon.h b/balloon.h > index d478e28..4602d85 100644 > --- a/balloon.h > +++ b/balloon.h > @@ -11,8 +11,8 @@ >  * >  */ > > -#ifndef _QEMU_BALLOON_H > -#define _QEMU_BALLOON_H > +#ifndef QEMU_BALLOON_H > +#define QEMU_BALLOON

Re: [Qemu-devel] [PATCH] Correct and standardize header guards in all header files

2011-06-06 Thread Markus Armbruster
Alexandre Raymond writes: > As per ISO/IEC 9899, Section 7.1.3 on reserved identifiers, > identifiers starting with an underscore are reserved. > > Therefore: > 1) Rename all incorrect header guards > > While I'm at it: > 2) Standardize header guards to "#ifndef SOMETHING_H" Consistency is good.

Re: [Qemu-devel] [PATCH] Correct and standardize header guards in all header files

2011-06-05 Thread Blue Swirl
On Sun, Jun 5, 2011 at 6:57 AM, Alexandre Raymond wrote: > As per ISO/IEC 9899, Section 7.1.3 on reserved identifiers, > identifiers starting with an underscore are reserved. > > Therefore: > 1) Rename all incorrect header guards > > While I'm at it: > 2) Standardize header guards to "#ifndef SOME