Re: [Qemu-devel] [PATCH] Consistently use qemu_macaddr_default_if_unset

2011-05-23 Thread Jan Kiszka
On 2011-05-23 10:43, Markus Armbruster wrote: > Jan Kiszka writes: > >> Drop the open-coded MAC assignment from net_init_nic and replace it with >> standard qemu_macaddr_default_if_unset which is also used by qdev. That >> avoid creating colliding MACs when instantiating NICs via different >> mec

Re: [Qemu-devel] [PATCH] Consistently use qemu_macaddr_default_if_unset

2011-05-23 Thread Markus Armbruster
Jan Kiszka writes: > Drop the open-coded MAC assignment from net_init_nic and replace it with > standard qemu_macaddr_default_if_unset which is also used by qdev. That > avoid creating colliding MACs when instantiating NICs via different > mechanisms. Should we explicitly mention that this may c

[Qemu-devel] [PATCH] Consistently use qemu_macaddr_default_if_unset

2011-05-20 Thread Jan Kiszka
Drop the open-coded MAC assignment from net_init_nic and replace it with standard qemu_macaddr_default_if_unset which is also used by qdev. That avoid creating colliding MACs when instantiating NICs via different mechanisms. This change requires to store the MAC as MACAddr in NICInfo, and the rema