Re: [Qemu-devel] [PATCH] Chage disk serial length from 20 to 36

2016-08-30 Thread Paolo Bonzini
On 30/08/2016 14:44, Markus Armbruster wrote: >> > There is no limit in the SCSI spec. 20 was copy-pasted from virtio-blk >> > which in turn was copy-pasted from ATA. So 36 is even more arbitrary, >> > but bumping it up too much might cause issues (e.g. who knows there's no >> > off-by-one some

Re: [Qemu-devel] [PATCH] Chage disk serial length from 20 to 36

2016-08-30 Thread Markus Armbruster
Paolo Bonzini writes: > On 30/08/2016 14:08, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> On 29/08/2016 09:52, ronyw...@synology.com wrote: From: ronyweng Openstack Cinder assigns volume a 36 characters uuid as serial. Qemu will shrinks the uuid to 20 characters

Re: [Qemu-devel] [PATCH] Chage disk serial length from 20 to 36

2016-08-30 Thread Paolo Bonzini
On 30/08/2016 14:08, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On 29/08/2016 09:52, ronyw...@synology.com wrote: >>> From: ronyweng >>> >>> Openstack Cinder assigns volume a 36 characters uuid as serial. >>> Qemu will shrinks the uuid to 20 characters, >>> missmatch with original u

Re: [Qemu-devel] [PATCH] Chage disk serial length from 20 to 36

2016-08-30 Thread Markus Armbruster
Paolo Bonzini writes: > On 29/08/2016 09:52, ronyw...@synology.com wrote: >> From: ronyweng >> >> Openstack Cinder assigns volume a 36 characters uuid as serial. >> Qemu will shrinks the uuid to 20 characters, >> missmatch with original uuid. >> >> Signed-off-by: Rony Weng >> --- >> hw/scsi/

Re: [Qemu-devel] [PATCH] Chage disk serial length from 20 to 36

2016-08-29 Thread Paolo Bonzini
On 29/08/2016 09:52, ronyw...@synology.com wrote: > From: ronyweng > > Openstack Cinder assigns volume a 36 characters uuid as serial. > Qemu will shrinks the uuid to 20 characters, > missmatch with original uuid. > > Signed-off-by: Rony Weng > --- > hw/scsi/scsi-disk.c | 4 ++-- > 1 file ch

[Qemu-devel] [PATCH] Chage disk serial length from 20 to 36

2016-08-29 Thread ronyweng
From: ronyweng Openstack Cinder assigns volume a 36 characters uuid as serial. Qemu will shrinks the uuid to 20 characters, missmatch with original uuid. Signed-off-by: Rony Weng --- hw/scsi/scsi-disk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/scsi/scsi-disk.c