Re: [Qemu-devel] [PATCH] COLO: remove the operation to clear connection list

2017-10-23 Thread Darren Kenny
That's consistent with the documented behaviour of g_hash_table_remove_all(). Reviewed-by: Darren Kenny Thanks, Darren. On Tue, Oct 24, 2017 at 03:27:59AM +0800, zhiyong...@ucloud.cn wrote: From: Zhi Yong Wu When hash table is created with g_hash_table_new_full(), the free function has

[Qemu-devel] [PATCH] COLO: remove the operation to clear connection list

2017-10-23 Thread zhiyong . wu
From: Zhi Yong Wu When hash table is created with g_hash_table_new_full(), the free function has been registered. So it isn't necessary since g_hash_table_remove_all() will call connection_destroy() for each connection struct automatically. Signed-off-by: Zhi Yong Wu --- net/colo.c |6

[Qemu-devel] [PATCH] COLO: remove the operation to clear connection list

2017-10-23 Thread zhiyong . wu
From: Zhi Yong Wu When hash table is created with g_hash_table_new_full(), the free function has been registered. So it isn't necessary since g_hash_table_remove_all() will call connection_destroy() for each connection struct automatically. Signed-off-by: Zhi Yong Wu --- net/colo.c |6

[Qemu-devel] [PATCH] COLO: remove the operation to clear connection list

2017-10-23 Thread Zhi Yong Wu
When hash table is created with g_hash_table_new_full(), the free function has been registered. So it isn't necessary since g_hash_table_remove_all() will call connection_destroy() for each connection struct automatically. Signed-off-by: Zhi Yong Wu --- net/colo.c |6 -- 1 files changed,

[Qemu-devel] [PATCH] COLO: remove the operation to clear connection list

2017-10-23 Thread Zhi Yong Wu
From 4439e5853f98fb4b32f346245a46414d3c7e2221 Mon Sep 17 00:00:00 2001 From: Zhi Yong Wu Date: Tue, 24 Oct 2017 03:19:00 +0800 Subject: [PATCH] COLO: remove the operation to clear connection list When hash table is created with g_hash_table_new_full(), the free function has been registered. So i