Re: [Qemu-devel] [PATCH] CODING_STYLE: update line length and mixed declaration rules

2015-08-26 Thread Markus Armbruster
John Snow writes: > On 08/25/2015 02:20 PM, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> On 19/06/2015 10:09, Andreas Färber wrote: >> -Lines are 80 characters; not longer. >> +Lines should be 80 characters; try not to make them longer. >> + >> +Sometimes it is hard

Re: [Qemu-devel] [PATCH] CODING_STYLE: update line length and mixed declaration rules

2015-08-25 Thread John Snow
On 08/25/2015 02:20 PM, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On 19/06/2015 10:09, Andreas Färber wrote: > -Lines are 80 characters; not longer. > +Lines should be 80 characters; try not to make them longer. > + > +Sometimes it is hard to do, especially when deal

Re: [Qemu-devel] [PATCH] CODING_STYLE: update line length and mixed declaration rules

2015-08-25 Thread Markus Armbruster
Paolo Bonzini writes: > On 19/06/2015 10:09, Andreas Färber wrote: >>> > -Lines are 80 characters; not longer. >>> > +Lines should be 80 characters; try not to make them longer. >>> > + >>> > +Sometimes it is hard to do, especially when dealing with QEMU subsystems >>> > +that use long function o

Re: [Qemu-devel] [PATCH] CODING_STYLE: update line length and mixed declaration rules

2015-06-19 Thread Paolo Bonzini
On 19/06/2015 10:09, Andreas Färber wrote: >> > -Lines are 80 characters; not longer. >> > +Lines should be 80 characters; try not to make them longer. >> > + >> > +Sometimes it is hard to do, especially when dealing with QEMU subsystems >> > +that use long function or symbol names. Even in that

Re: [Qemu-devel] [PATCH] CODING_STYLE: update line length and mixed declaration rules

2015-06-19 Thread Andreas Färber
Am 19.06.2015 um 09:29 schrieb Paolo Bonzini: > 1) Line lengths above 80 characters do exist. They are rare, but > they happen from time to time. An ignored rule is worse than an > exception to the rule, so do the latter. > > 2) Mixed declarations also do exist at the top of #ifdef blocks. > Rem

Re: [Qemu-devel] [PATCH] CODING_STYLE: update line length and mixed declaration rules

2015-06-19 Thread Paolo Bonzini
On 19/06/2015 09:53, Thomas Huth wrote: > > - WARN("line over 80 characters\n" . $herecurr); > > + if ($length > 90) { > > + ERROR("line over 90 characters\n" . $herecurr); > > + } if ($length > 80) { > > Did you mea

Re: [Qemu-devel] [PATCH] CODING_STYLE: update line length and mixed declaration rules

2015-06-19 Thread Thomas Huth
On Fri, 19 Jun 2015 09:29:04 +0200 Paolo Bonzini wrote: > 1) Line lengths above 80 characters do exist. They are rare, but > they happen from time to time. An ignored rule is worse than an > exception to the rule, so do the latter. > > 2) Mixed declarations also do exist at the top of #ifdef b

[Qemu-devel] [PATCH] CODING_STYLE: update line length and mixed declaration rules

2015-06-19 Thread Paolo Bonzini
1) Line lengths above 80 characters do exist. They are rare, but they happen from time to time. An ignored rule is worse than an exception to the rule, so do the latter. 2) Mixed declarations also do exist at the top of #ifdef blocks. Remark on this particular usage and suggest an alternative.