Re: [Qemu-devel] [PATCH] CODING_STYLE: Reserve qemu_ prefix for library wrappers

2010-03-22 Thread Anthony Liguori
On 03/11/2010 08:48 AM, Avi Kivity wrote: Signed-off-by: Avi Kivity --- CODING_STYLE |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/CODING_STYLE b/CODING_STYLE index a579cb1..92036f3 100644 --- a/CODING_STYLE +++ b/CODING_STYLE @@ -49,6 +49,9 @@ and is therefore lik

Re: [Qemu-devel] [PATCH] CODING_STYLE: Reserve qemu_ prefix for library wrappers

2010-03-13 Thread Edgar E. Iglesias
On Sat, Mar 13, 2010 at 10:17:37AM +0200, Avi Kivity wrote: > On 03/13/2010 04:55 AM, Edgar E. Iglesias wrote: > > On Thu, Mar 11, 2010 at 04:48:43PM +0200, Avi Kivity wrote: > > > >> Signed-off-by: Avi Kivity > >> --- > >> CODING_STYLE |3 +++ > >> 1 files changed, 3 insertions(+), 0 de

Re: [Qemu-devel] [PATCH] CODING_STYLE: Reserve qemu_ prefix for library wrappers

2010-03-13 Thread Avi Kivity
On 03/13/2010 04:55 AM, Edgar E. Iglesias wrote: On Thu, Mar 11, 2010 at 04:48:43PM +0200, Avi Kivity wrote: Signed-off-by: Avi Kivity --- CODING_STYLE |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/CODING_STYLE b/CODING_STYLE index a579cb1..92036f3 100644 ---

Re: [Qemu-devel] [PATCH] CODING_STYLE: Reserve qemu_ prefix for library wrappers

2010-03-12 Thread Edgar E. Iglesias
On Thu, Mar 11, 2010 at 04:48:43PM +0200, Avi Kivity wrote: > Signed-off-by: Avi Kivity > --- > CODING_STYLE |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/CODING_STYLE b/CODING_STYLE > index a579cb1..92036f3 100644 > --- a/CODING_STYLE > +++ b/CODING_STYLE > @@

Re: [Qemu-devel] [PATCH] CODING_STYLE: Reserve qemu_ prefix for library wrappers

2010-03-12 Thread Paul Brook
> +When wrapping standard library functions, use the prefix qemu_ to alert > +readers that they are seeing a wrapped version; otherwise avoid this > prefix. + I'm tempted to say "When wrapping or providing functionality that could easily be confused with standard library functions [...]". I'm n

Re: [Qemu-devel] [PATCH] CODING_STYLE: Reserve qemu_ prefix for library wrappers

2010-03-11 Thread Aurelien Jarno
On Thu, Mar 11, 2010 at 04:48:43PM +0200, Avi Kivity wrote: > Signed-off-by: Avi Kivity > --- > CODING_STYLE |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/CODING_STYLE b/CODING_STYLE > index a579cb1..92036f3 100644 > --- a/CODING_STYLE > +++ b/CODING_STYLE > @@

Re: [Qemu-devel] [PATCH] CODING_STYLE: Reserve qemu_ prefix for library wrappers

2010-03-11 Thread Markus Armbruster
Avi Kivity writes: > Signed-off-by: Avi Kivity > --- > CODING_STYLE |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/CODING_STYLE b/CODING_STYLE > index a579cb1..92036f3 100644 > --- a/CODING_STYLE > +++ b/CODING_STYLE > @@ -49,6 +49,9 @@ and is therefore likely t

[Qemu-devel] [PATCH] CODING_STYLE: Reserve qemu_ prefix for library wrappers

2010-03-11 Thread Avi Kivity
Signed-off-by: Avi Kivity --- CODING_STYLE |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/CODING_STYLE b/CODING_STYLE index a579cb1..92036f3 100644 --- a/CODING_STYLE +++ b/CODING_STYLE @@ -49,6 +49,9 @@ and is therefore likely to be changed. Typedefs are used to elim