Re: [Qemu-devel] [PATCH] Avoid segfault in cpu_dump_state

2012-05-30 Thread Andreas Färber
Am 30.05.2012 09:58, schrieb Alexander Graf: > > On 23.05.2012, at 17:43, Fabien Chouteau wrote: > >> On 05/16/2012 03:39 PM, Fabien Chouteau wrote: >>> On 05/16/2012 10:29 AM, Fabien Chouteau wrote: On 05/16/2012 05:50 AM, Andreas Färber wrote: > Am 15.05.2012 18:08, schrieb Fabien Chou

Re: [Qemu-devel] [PATCH] Avoid segfault in cpu_dump_state

2012-05-30 Thread Fabien Chouteau
On 05/30/2012 09:58 AM, Alexander Graf wrote: > > On 23.05.2012, at 17:43, Fabien Chouteau wrote: > >> On 05/16/2012 03:39 PM, Fabien Chouteau wrote: >>> On 05/16/2012 10:29 AM, Fabien Chouteau wrote: On 05/16/2012 05:50 AM, Andreas Färber wrote: > Am 15.05.2012 18:08, schrieb Fabien Cho

Re: [Qemu-devel] [PATCH] Avoid segfault in cpu_dump_state

2012-05-30 Thread Alexander Graf
On 23.05.2012, at 17:43, Fabien Chouteau wrote: > On 05/16/2012 03:39 PM, Fabien Chouteau wrote: >> On 05/16/2012 10:29 AM, Fabien Chouteau wrote: >>> On 05/16/2012 05:50 AM, Andreas Färber wrote: Am 15.05.2012 18:08, schrieb Fabien Chouteau: > On 05/15/2012 03:31 PM, Andreas Färber wrot

Re: [Qemu-devel] [PATCH] Avoid segfault in cpu_dump_state

2012-05-23 Thread Fabien Chouteau
On 05/16/2012 03:39 PM, Fabien Chouteau wrote: > On 05/16/2012 10:29 AM, Fabien Chouteau wrote: >> On 05/16/2012 05:50 AM, Andreas Färber wrote: >>> Am 15.05.2012 18:08, schrieb Fabien Chouteau: On 05/15/2012 03:31 PM, Andreas Färber wrote: > Am 15.05.2012 11:39, schrieb Fabien Chouteau: >

Re: [Qemu-devel] [PATCH] Avoid segfault in cpu_dump_state

2012-05-16 Thread Fabien Chouteau
On 05/16/2012 10:29 AM, Fabien Chouteau wrote: > On 05/16/2012 05:50 AM, Andreas Färber wrote: >> Am 15.05.2012 18:08, schrieb Fabien Chouteau: >>> On 05/15/2012 03:31 PM, Andreas Färber wrote: Am 15.05.2012 11:39, schrieb Fabien Chouteau: > Do not call cpu_dump_state if logfile is NULL. >

Re: [Qemu-devel] [PATCH] Avoid segfault in cpu_dump_state

2012-05-16 Thread Fabien Chouteau
On 05/16/2012 05:50 AM, Andreas Färber wrote: > Am 15.05.2012 18:08, schrieb Fabien Chouteau: >> On 05/15/2012 03:31 PM, Andreas Färber wrote: >>> Am 15.05.2012 11:39, schrieb Fabien Chouteau: Do not call cpu_dump_state if logfile is NULL. >>> >>> And where is log_cpu_state() being called from

Re: [Qemu-devel] [PATCH] Avoid segfault in cpu_dump_state

2012-05-15 Thread Andreas Färber
Am 15.05.2012 18:08, schrieb Fabien Chouteau: > On 05/15/2012 03:31 PM, Andreas Färber wrote: >> Am 15.05.2012 11:39, schrieb Fabien Chouteau: >>> Do not call cpu_dump_state if logfile is NULL. >> >> And where is log_cpu_state() being called from? Its caller is passing >> NULL already then. >> > >

Re: [Qemu-devel] [PATCH] Avoid segfault in cpu_dump_state

2012-05-15 Thread Peter Maydell
On 15 May 2012 17:45, Fabien Chouteau wrote: > On 05/15/2012 06:20 PM, Peter Maydell wrote: >> The question is which of the following two options we want: >> (1) callers should be guarding the calls to log_cpu_state() with >> checks for qemu_log_enabled() or qemu_loglevel_mask() >> (2) log_cpu_sta

Re: [Qemu-devel] [PATCH] Avoid segfault in cpu_dump_state

2012-05-15 Thread Fabien Chouteau
On 05/15/2012 06:20 PM, Peter Maydell wrote: > On 15 May 2012 17:08, Fabien Chouteau wrote: >> On 05/15/2012 03:31 PM, Andreas Färber wrote: >>> Am 15.05.2012 11:39, schrieb Fabien Chouteau: Do not call cpu_dump_state if logfile is NULL. >>> >>> And where is log_cpu_state() being called from?

Re: [Qemu-devel] [PATCH] Avoid segfault in cpu_dump_state

2012-05-15 Thread Peter Maydell
On 15 May 2012 17:08, Fabien Chouteau wrote: > On 05/15/2012 03:31 PM, Andreas Färber wrote: >> Am 15.05.2012 11:39, schrieb Fabien Chouteau: >>> Do not call cpu_dump_state if logfile is NULL. >> >> And where is log_cpu_state() being called from? Its caller is passing >> NULL already then. > No,

Re: [Qemu-devel] [PATCH] Avoid segfault in cpu_dump_state

2012-05-15 Thread Fabien Chouteau
On 05/15/2012 03:31 PM, Andreas Färber wrote: > Am 15.05.2012 11:39, schrieb Fabien Chouteau: >> Do not call cpu_dump_state if logfile is NULL. > > And where is log_cpu_state() being called from? Its caller is passing > NULL already then. > No, logfile is a global variable. log_cpu_state() takes

Re: [Qemu-devel] [PATCH] Avoid segfault in cpu_dump_state

2012-05-15 Thread Andreas Färber
Am 15.05.2012 11:39, schrieb Fabien Chouteau: > Do not call cpu_dump_state if logfile is NULL. And where is log_cpu_state() being called from? Its caller is passing NULL already then. Andreas > > Signed-off-by: Fabien Chouteau > --- > qemu-log.h |7 ++- > 1 file changed, 6 insertions(

[Qemu-devel] [PATCH] Avoid segfault in cpu_dump_state

2012-05-15 Thread Fabien Chouteau
Do not call cpu_dump_state if logfile is NULL. Signed-off-by: Fabien Chouteau --- qemu-log.h |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/qemu-log.h b/qemu-log.h index fccfb110..2cd5ffa 100644 --- a/qemu-log.h +++ b/qemu-log.h @@ -51,7 +51,12 @@ extern int logleve