Re: [Qemu-devel] [PATCH] Allow AF_UNIX sockets to be disabled on non-Windows

2008-01-25 Thread Ian Jackson
Johannes Schindelin writes ("Re: [Qemu-devel] [PATCH] Allow AF_UNIX sockets to be disabled on non-Windows"): > Yes, that is very ugly. But changing it to > #ifndef NO_AF_UNIX_SOCKETS > it actually gives you a bit of documentation what the code does, in > addition

Re: [Qemu-devel] [PATCH] Allow AF_UNIX sockets to be disabled on non-Windows

2008-01-25 Thread Johannes Schindelin
Hi, On Fri, 25 Jan 2008, Ian Jackson wrote: > But when the existing code says > > } > #ifndef _WIN32 > if (strstart(display, "unix:", &p)) { > addr = (struct sockaddr *)&uaddr; > addrlen = sizeof(uaddr); > etc. > > then changing it to something like > > #if !(d

Re: [Qemu-devel] [PATCH] Allow AF_UNIX sockets to be disabled on non-Windows

2008-01-25 Thread Ian Jackson
Anthony Liguori writes ("Re: [Qemu-devel] [PATCH] Allow AF_UNIX sockets to be disabled on non-Windows"): > Presumably, this is because you're compiling for MiniOS? Why not just > add a _MINIOS define and then add an appropriate #ifndef. Yes. We'll probably add a

Re: [Qemu-devel] [PATCH] Allow AF_UNIX sockets to be disabled on non-Windows

2008-01-25 Thread Anthony Liguori
Ian Jackson wrote: The patch below makes it possible to disable AF_UNIX (unix-domain) sockets in host environments which do not define _WIN32, by adding -DNO_UNIX_SOCKETS to the compiler flags. This is useful in the effectively-embedded qemu host which are going to be using for device emulation

[Qemu-devel] [PATCH] Allow AF_UNIX sockets to be disabled on non-Windows

2008-01-25 Thread Ian Jackson
The patch below makes it possible to disable AF_UNIX (unix-domain) sockets in host environments which do not define _WIN32, by adding -DNO_UNIX_SOCKETS to the compiler flags. This is useful in the effectively-embedded qemu host which are going to be using for device emulation in Xen. Ian. Index: