Re: [Qemu-devel] [PATCH] Adds virtio_net as the default netcard for mips boston board.

2019-04-02 Thread Peter Maydell
On Wed, 3 Apr 2019 at 11:52, Tommy Jin wrote: > That command line option doesn't work for boston, although I didn't get any > obvious error, no Ethernet card appears either. Does the guest kernel find the PCI device (eg appears in kernel bootup messages, appears in 'lspci' output)? It's worth do

Re: [Qemu-devel] [PATCH] Adds virtio_net as the default netcard for mips boston board.

2019-04-02 Thread Tommy Jin
il.com Subject: Re: [Qemu-devel] [PATCH] Adds virtio_net as the default netcard for mips boston board. On Tue, 2 Apr 2019 at 14:24, Tommy Jin wrote: > For the option2, I think specify the network model in command line is > not enough, per my understanding, we still need to create the dev

Re: [Qemu-devel] [PATCH] Adds virtio_net as the default netcard for mips boston board.

2019-04-02 Thread Peter Maydell
On Tue, 2 Apr 2019 at 14:24, Tommy Jin wrote: > For the option2, I think specify the network model in command line is > not enough, per my understanding, we still need to create the device > using API like pci_create && qdev_set_nic_properties && qdev_init_nofail, > otherwise we'll get error promp

Re: [Qemu-devel] [PATCH] Adds virtio_net as the default netcard for mips boston board.

2019-04-02 Thread Tommy Jin
.org; pburton.wavecomp....@gmail.com Subject: Re: [Qemu-devel] [PATCH] Adds virtio_net as the default netcard for mips boston board. On Tue, 2 Apr 2019 at 09:29, Tommy Jin wrote: > If always creating virtio-net-pci device is not a good idea, is it > feasible to make virtio-net-pci as a

Re: [Qemu-devel] [PATCH] Adds virtio_net as the default netcard for mips boston board.

2019-04-01 Thread Tommy Jin
:qemu-devel@nongnu.org>; > pburton.wavecomp....@gmail.com<mailto:pburton.wavecomp@gmail.com> > Subject: Re: [Qemu-devel] [PATCH] Adds virtio_net as the default netcard for > mips boston board. > > > > On Apr 1, 2019 11:39 AM, "Peter Maydell" > m

Re: [Qemu-devel] [PATCH] Adds virtio_net as the default netcard for mips boston board.

2019-04-01 Thread Aleksandar Markovic
ndar Markovic > Sent: Tuesday, April 2, 2019 10:25 AM > To: Peter Maydell > Cc: Tommy Jin; qemu-devel@nongnu.org; pburton.wavecomp@gmail.com > Subject: Re: [Qemu-devel] [PATCH] Adds virtio_net as the default netcard for mips boston board. > > > > On Apr 1, 2019 11:39 AM,

Re: [Qemu-devel] [PATCH] Adds virtio_net as the default netcard for mips boston board.

2019-04-01 Thread Tommy Jin
Best regards, Tommy From: Aleksandar Markovic Sent: Tuesday, April 2, 2019 10:25 AM To: Peter Maydell Cc: Tommy Jin; qemu-devel@nongnu.org; pburton.wavecomp@gmail.com Subject: Re: [Qemu-devel] [PATCH] Adds virtio_net as the default netcard for mips boston board. On Apr 1, 2019 11:3

Re: [Qemu-devel] [PATCH] Adds virtio_net as the default netcard for mips boston board.

2019-04-01 Thread Peter Maydell
On Tue, 2 Apr 2019 at 09:29, Tommy Jin wrote: > If always creating virtio-net-pci device is not a good idea, is it > feasible to make virtio-net-pci as an option for boston without > using libvirt? It's always an option, just specify it on the command line. > Actually, Botson board can have an I

Re: [Qemu-devel] [PATCH] Adds virtio_net as the default netcard for mips boston board.

2019-04-01 Thread Aleksandar Markovic
On Apr 1, 2019 11:39 AM, "Peter Maydell" wrote: > > On Mon, 1 Apr 2019 at 16:23, Tommy Jin wrote: > > > > Boston didn't bring up any netcard by default, this is not so convenient for users who are verifying network related functionalities on this board. > > As the linux kernel has already support

Re: [Qemu-devel] [PATCH] Adds virtio_net as the default netcard for mips boston board.

2019-04-01 Thread Peter Maydell
On Mon, 1 Apr 2019 at 16:23, Tommy Jin wrote: > > Boston didn't bring up any netcard by default, this is not so convenient for > users who are verifying network related functionalities on this board. > As the linux kernel has already supported virtio_net, now add a virtio > netcard for boston, t

[Qemu-devel] [PATCH] Adds virtio_net as the default netcard for mips boston board.

2019-04-01 Thread Tommy Jin
Boston didn't bring up any netcard by default, this is not so convenient for users who are verifying network related functionalities on this board. As the linux kernel has already supported virtio_net, now add a virtio netcard for boston, to make virtio work properly, please: 1. set virtio net op