Re: [Qemu-devel] [PATCH] Add minimal Vexpress Cortex A15 support

2011-12-06 Thread Peter Maydell
On 6 December 2011 13:12, Avi Kivity wrote: > On 12/06/2011 02:48 PM, Peter Maydell wrote: >> Real hardware runs the boot ROM. The boot ROM is an unredistributable >> binary blob, and in any case we almost certainly don't implement >> the hardware well enough to pass the boot ROM's self tests and

Re: [Qemu-devel] [PATCH] Add minimal Vexpress Cortex A15 support

2011-12-06 Thread Avi Kivity
On 12/06/2011 02:48 PM, Peter Maydell wrote: > On 6 December 2011 12:39, Avi Kivity wrote: > > On 12/06/2011 02:35 PM, Peter Maydell wrote: > >> On 6 December 2011 12:28, Avi Kivity wrote: > >> Do you have a better suggestion in this case? We've had the same > >> code in the realview board since

Re: [Qemu-devel] [PATCH] Add minimal Vexpress Cortex A15 support

2011-12-06 Thread Peter Maydell
On 6 December 2011 12:39, Avi Kivity wrote: > On 12/06/2011 02:35 PM, Peter Maydell wrote: >> On 6 December 2011 12:28, Avi Kivity wrote: >> Do you have a better suggestion in this case? We've had the same >> code in the realview board since 2007 when ARM SMP support was first >> added... > > No

Re: [Qemu-devel] [PATCH] Add minimal Vexpress Cortex A15 support

2011-12-06 Thread Avi Kivity
On 12/06/2011 02:35 PM, Peter Maydell wrote: > On 6 December 2011 12:28, Avi Kivity wrote: > > On 12/01/2011 03:37 AM, bill4car...@gmail.com wrote: > >> +/* ??? Hack to map an additional page of ram for the secondary CPU > >> + startup code. I guess this works on real hardware because t

Re: [Qemu-devel] [PATCH] Add minimal Vexpress Cortex A15 support

2011-12-06 Thread Peter Maydell
On 6 December 2011 12:28, Avi Kivity wrote: > On 12/01/2011 03:37 AM, bill4car...@gmail.com wrote: >> +    /* ??? Hack to map an additional page of ram for the secondary CPU >> +       startup code.  I guess this works on real hardware because the >> +       BootROM happens to be in ROM/flash or i

Re: [Qemu-devel] [PATCH] Add minimal Vexpress Cortex A15 support

2011-12-06 Thread Avi Kivity
On 12/01/2011 03:37 AM, bill4car...@gmail.com wrote: > From: Bill Carson > > This patch adds minimal codes to support A15 which enables ARM KVM could > run Guest OS build with Versatile Express Cortex-A15x4 tile. > > + > +static inline int > +gic_get_current_cpu(void) > +{ > + return cpu_single_

Re: [Qemu-devel] [PATCH] Add minimal Vexpress Cortex A15 support

2011-12-05 Thread Peter Maydell
On 5 December 2011 17:59, Andreas Färber wrote: > Am 01.12.2011 02:37, schrieb bill4car...@gmail.com: >> + * ARM A15MPCore internal peripheral emulation (common code). > > ARM Cortex-A15 MPCore, please. No need to repeat the short file name. (also it's not "common code" with anything.) The priva

Re: [Qemu-devel] [PATCH] Add minimal Vexpress Cortex A15 support

2011-12-05 Thread Andreas Färber
Am 01.12.2011 02:37, schrieb bill4car...@gmail.com: > From: Bill Carson > > This patch adds minimal codes to support A15 which enables ARM KVM could > run Guest OS build with Versatile Express Cortex-A15x4 tile. > > Signed-off-by: Bill Carson > --- > diff --git a/hw/a15mpcore.c b/hw/a15mpcore

Re: [Qemu-devel] [PATCH] Add minimal Vexpress Cortex A15 support

2011-12-01 Thread Peter Maydell
On 1 December 2011 11:29, Peter Maydell wrote: > On 1 December 2011 01:37,   wrote: >> Qemu based on: >> git://git.linaro.org/qemu/qemu-linaro.git > > Please don't post patches to upstream which are based on qemu-linaro. > This work should be entirely doable against upstream qemu. To clarify that

Re: [Qemu-devel] [PATCH] Add minimal Vexpress Cortex A15 support

2011-12-01 Thread Peter Maydell
On 1 December 2011 01:37, wrote: > Qemu based on: > git://git.linaro.org/qemu/qemu-linaro.git Please don't post patches to upstream which are based on qemu-linaro. This work should be entirely doable against upstream qemu. You don't say whether you've tested this with TCG -- done correctly it s

[Qemu-devel] [PATCH] Add minimal Vexpress Cortex A15 support

2011-11-30 Thread bill4carson
From: Bill Carson This patch adds minimal codes to support A15 which enables ARM KVM could run Guest OS build with Versatile Express Cortex-A15x4 tile. Signed-off-by: Bill Carson --- Makefile.target |2 +- hw/a15mpcore.c | 118 +++ hw/vexpress.c