Re: [Qemu-devel] [PATCH] Add backing file option to qemu-img create help.

2014-05-13 Thread Kevin Wolf
Am 12.05.2014 um 19:02 hat Eric Blake geschrieben: > On 05/12/2014 10:36 AM, Kevin Wolf wrote: > > >>> rebase [-q] [-f fmt] [-t cache] [-p] [-u] -b backing_file [-F > >>> backing_fmt] filename > >> > >> 'rebase' lacks -o; so it must continue to document -b. This thread was > >> started in context

Re: [Qemu-devel] [PATCH] Add backing file option to qemu-img create help.

2014-05-12 Thread Mike Day
On Mon, May 12, 2014 at 12:36 PM, Kevin Wolf wrote: > What would qemu-img rebase do with -o? It is just for (safely) changing > the backing file, not for updating options. There is qemu-img amend for > that, and it does have an -o option. A little background ... I'm writing a 4-day KVM training

Re: [Qemu-devel] [PATCH] Add backing file option to qemu-img create help.

2014-05-12 Thread Eric Blake
On 05/12/2014 10:36 AM, Kevin Wolf wrote: >>> rebase [-q] [-f fmt] [-t cache] [-p] [-u] -b backing_file [-F >>> backing_fmt] filename >> >> 'rebase' lacks -o; so it must continue to document -b. This thread was >> started in context to the 'create' subcommand, not the 'rebase' >> subcommand. (Ar

Re: [Qemu-devel] [PATCH] Add backing file option to qemu-img create help.

2014-05-12 Thread Kevin Wolf
Am 12.05.2014 um 18:32 hat Eric Blake geschrieben: > On 05/12/2014 10:05 AM, Mike Day wrote: > > On Mon, May 12, 2014 at 11:53 AM, Eric Blake wrote: > >> Ah, but it is: > >> > >> $ qemu-img create -f qcow2 -o help > >> Supported options: > >> size Virtual disk size > >> compat

Re: [Qemu-devel] [PATCH] Add backing file option to qemu-img create help.

2014-05-12 Thread Eric Blake
On 05/12/2014 10:05 AM, Mike Day wrote: > On Mon, May 12, 2014 at 11:53 AM, Eric Blake wrote: >> Ah, but it is: >> >> $ qemu-img create -f qcow2 -o help >> Supported options: >> size Virtual disk size >> compat Compatibility level (0.10 or 1.1) >> backing_file File name o

Re: [Qemu-devel] [PATCH] Add backing file option to qemu-img create help.

2014-05-12 Thread Mike Day
On Mon, May 12, 2014 at 11:53 AM, Eric Blake wrote: > Ah, but it is: > > $ qemu-img create -f qcow2 -o help > Supported options: > size Virtual disk size > compat Compatibility level (0.10 or 1.1) > backing_file File name of a base image > backing_fmt Image format of

Re: [Qemu-devel] [PATCH] Add backing file option to qemu-img create help.

2014-05-12 Thread Eric Blake
On 05/12/2014 09:36 AM, Mike Day wrote: > On Mon, May 12, 2014 at 11:20 AM, Eric Blake wrote: >> Online where? In 'qemu-img --help', or on some web page (at what URL)? > > http://qemu.weilnetz.de/qemu-doc.html#vm_005fsnapshots Not an official qemu reference; nothing we can do about out-of-date

Re: [Qemu-devel] [PATCH] Add backing file option to qemu-img create help.

2014-05-12 Thread Mike Day
On Mon, May 12, 2014 at 11:20 AM, Eric Blake wrote: > Online where? In 'qemu-img --help', or on some web page (at what URL)? http://qemu.weilnetz.de/qemu-doc.html#vm_005fsnapshots -o backing file is not documented in the help command. Mike

Re: [Qemu-devel] [PATCH] Add backing file option to qemu-img create help.

2014-05-12 Thread Eric Blake
On 05/12/2014 09:13 AM, Kevin Wolf wrote: > Am 12.05.2014 um 17:05 hat Eric Blake geschrieben: >> On 05/12/2014 06:35 AM, Mike Day wrote: >>> For the create subcommand the backing file (-b) option is documented >>> on-line but not in the binary. Add it. Online where? In 'qemu-img --help', or on s

Re: [Qemu-devel] [PATCH] Add backing file option to qemu-img create help.

2014-05-12 Thread Kevin Wolf
Am 12.05.2014 um 17:05 hat Eric Blake geschrieben: > On 05/12/2014 06:35 AM, Mike Day wrote: > > For the create subcommand the backing file (-b) option is documented > > on-line but not in the binary. Add it. > > > > Signed-off-by: Mike Day > > --- > > qemu-img-cmds.hx | 4 ++-- > > 1 file chang

Re: [Qemu-devel] [PATCH] Add backing file option to qemu-img create help.

2014-05-12 Thread Eric Blake
On 05/12/2014 06:35 AM, Mike Day wrote: > For the create subcommand the backing file (-b) option is documented > on-line but not in the binary. Add it. > > Signed-off-by: Mike Day > --- > qemu-img-cmds.hx | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/qemu-img-cmds

[Qemu-devel] [PATCH] Add backing file option to qemu-img create help.

2014-05-12 Thread Mike Day
For the create subcommand the backing file (-b) option is documented on-line but not in the binary. Add it. Signed-off-by: Mike Day --- qemu-img-cmds.hx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx index d029609..7724709 100644 --- a