Re: [Qemu-devel] [PATCH] Acceptance tests: add Linux initrd checking test

2018-10-18 Thread Eduardo Habkost
On Thu, Oct 18, 2018 at 07:52:58PM -0400, Cleber Rosa wrote: [...] > >>> +expected_msg = r'.*initrd is too large.*max: \d+, need \d+.*' > >> > >> I'd be a bit more assertive here and do something like: > >> > >> expected_msg = r'.*initrd is too large.*max: \d+, need %d\)' % > >> m

Re: [Qemu-devel] [PATCH] Acceptance tests: add Linux initrd checking test

2018-10-18 Thread Cleber Rosa
On 10/18/18 6:09 PM, Eduardo Habkost wrote: > On Thu, Oct 18, 2018 at 05:45:56PM -0400, Cleber Rosa wrote: >> >> >> On 10/18/18 12:20 PM, Wainer dos Santos Moschetta wrote: >>> QEMU used to exits with a not accurate error message when >>> an initrd >= 2GB was passed. That was fixed on patch: >>>

Re: [Qemu-devel] [PATCH] Acceptance tests: add Linux initrd checking test

2018-10-18 Thread Eduardo Habkost
On Thu, Oct 18, 2018 at 05:45:56PM -0400, Cleber Rosa wrote: > > > On 10/18/18 12:20 PM, Wainer dos Santos Moschetta wrote: > > QEMU used to exits with a not accurate error message when > > an initrd >= 2GB was passed. That was fixed on patch: > > > > commit f3839fda5771596152b75dd1e1a6d050e

Re: [Qemu-devel] [PATCH] Acceptance tests: add Linux initrd checking test

2018-10-18 Thread Cleber Rosa
On 10/18/18 12:20 PM, Wainer dos Santos Moschetta wrote: > QEMU used to exits with a not accurate error message when > an initrd >= 2GB was passed. That was fixed on patch: > > commit f3839fda5771596152b75dd1e1a6d050e6e6e380 > Author: Li Zhijian > Date: Thu Sep 13 18:07:13

Re: [Qemu-devel] [PATCH] Acceptance tests: add Linux initrd checking test

2018-10-18 Thread Cleber Rosa
On 10/18/18 3:11 PM, Caio Carrara wrote: > Hi Wainer, > > On 18-10-2018 13:20, Wainer dos Santos Moschetta wrote: >> [...] >> +def test_with_2GB_file_should_exit_error_msg(self): >> +""" >> +Pretends to boot QEMU with an initrd file with size of 2GB >> +and expect it

Re: [Qemu-devel] [PATCH] Acceptance tests: add Linux initrd checking test

2018-10-18 Thread Cleber Rosa
On 10/18/18 12:44 PM, Philippe Mathieu-Daudé wrote: > On 18/10/2018 18:20, Wainer dos Santos Moschetta wrote: >> QEMU used to exits with a not accurate error message when >> an initrd >= 2GB was passed. That was fixed on patch: >> >> commit f3839fda5771596152b75dd1e1a6d050e6e6e380 >> A

Re: [Qemu-devel] [PATCH] Acceptance tests: add Linux initrd checking test

2018-10-18 Thread Caio Carrara
Hi Wainer, On 18-10-2018 13:20, Wainer dos Santos Moschetta wrote: > [...] > +def test_with_2GB_file_should_exit_error_msg(self): > +""" > +Pretends to boot QEMU with an initrd file with size of 2GB > +and expect it exits with error message. > +Regression test f

Re: [Qemu-devel] [PATCH] Acceptance tests: add Linux initrd checking test

2018-10-18 Thread Philippe Mathieu-Daudé
On 18/10/2018 18:20, Wainer dos Santos Moschetta wrote: > QEMU used to exits with a not accurate error message when > an initrd >= 2GB was passed. That was fixed on patch: > > commit f3839fda5771596152b75dd1e1a6d050e6e6e380 > Author: Li Zhijian > Date: Thu Sep 13 18:07:13 2018

[Qemu-devel] [PATCH] Acceptance tests: add Linux initrd checking test

2018-10-18 Thread Wainer dos Santos Moschetta
QEMU used to exits with a not accurate error message when an initrd >= 2GB was passed. That was fixed on patch: commit f3839fda5771596152b75dd1e1a6d050e6e6e380 Author: Li Zhijian Date: Thu Sep 13 18:07:13 2018 +0800 change get_image_size return type to int64_t