Re: [Qemu-devel] [PATCH] A different way to ask for readonly drive

2009-12-17 Thread Jamie Lokier
Kevin Wolf wrote: > Am 17.12.2009 14:16, schrieb Jamie Lokier: > You can decide to protect your images with the qemu readonly option and > get the protection that qemu defines, or you take the permissions of the > OS and get from the OS whatever the definition of that protection is > (including wri

Re: [Qemu-devel] [PATCH] A different way to ask for readonly drive

2009-12-17 Thread Markus Armbruster
Jamie Lokier writes: > Christoph Hellwig wrote: >> On Tue, Dec 15, 2009 at 06:45:01PM +, Jamie Lokier wrote: >> > access=rw >> > access=ro >> > access=auto (default) >> >> Yes, that sounds like the least clumsy one. I still think the current >> implementation is a very bad default, though.

Re: [Qemu-devel] [PATCH] A different way to ask for readonly drive

2009-12-17 Thread Kevin Wolf
Am 17.12.2009 14:16, schrieb Jamie Lokier: > Christoph Hellwig wrote: >> On Tue, Dec 15, 2009 at 06:45:01PM +, Jamie Lokier wrote: >>> access=rw >>> access=ro >>> access=auto (default) >> >> Yes, that sounds like the least clumsy one. I still think the current >> implementation is a very bad

Re: [Qemu-devel] [PATCH] A different way to ask for readonly drive

2009-12-17 Thread Jamie Lokier
Christoph Hellwig wrote: > On Tue, Dec 15, 2009 at 06:45:01PM +, Jamie Lokier wrote: > > access=rw > > access=ro > > access=auto (default) > > Yes, that sounds like the least clumsy one. I still think the current > implementation is a very bad default, though. Without agreeing or disagreein

Re: [Qemu-devel] [PATCH] A different way to ask for readonly drive

2009-12-17 Thread Richard W.M. Jones
On Mon, Dec 14, 2009 at 03:35:07PM +0200, Naphtali Sprei wrote: > block.c | 29 + > block.h |7 +-- > hw/xen_disk.c |3 ++- > monitor.c |2 +- > qemu-config.c |4 ++-- > qemu-img.c| 14 -- > qemu-nbd.c|2 +-

Re: [Qemu-devel] [PATCH] A different way to ask for readonly drive

2009-12-17 Thread Christoph Hellwig
On Tue, Dec 15, 2009 at 06:45:01PM +, Jamie Lokier wrote: > access=rw > access=ro > access=auto (default) Yes, that sounds like the least clumsy one. I still think the current implementation is a very bad default, though.

Re: [Qemu-devel] [PATCH] A different way to ask for readonly drive

2009-12-15 Thread Stefan Weil
Jamie Lokier schrieb: > Stefan Weil wrote: > >> So here are my suggestions: >> >> read_write=rw >> read_write=ro >> read_write=rw-ro >> >> or >> >> access=rw >> access=ro >> access=rw-ro >> > > Mine: > > access=rw > access=ro > access=auto (default) > > -- Jamie Looks good. Best suggestio

Re: [Qemu-devel] [PATCH] A different way to ask for readonly drive

2009-12-15 Thread Jamie Lokier
Stefan Weil wrote: > So here are my suggestions: > > read_write=rw > read_write=ro > read_write=rw-ro > > or > > access=rw > access=ro > access=rw-ro Mine: access=rw access=ro access=auto (default) -- Jamie

Re: [Qemu-devel] [PATCH] A different way to ask for readonly drive

2009-12-15 Thread Kevin Wolf
Am 14.12.2009 14:35, schrieb Naphtali Sprei: > Hi, > After feedback from Red Hat guys, I've decided to slightly modify the > approach to drive's readonly. > The new approach also addresses the silent fall-back to open the drives' file > as read-only when read-write fails > (permission denied) tha

Re: [Qemu-devel] [PATCH] A different way to ask for readonly drive

2009-12-14 Thread Stefan Weil
Naphtali Sprei schrieb: > Hi, > After feedback from Red Hat guys, I've decided to slightly modify the > approach to drive's readonly. > The new approach also addresses the silent fall-back to open the drives' file > as read-only when read-write fails > (permission denied) that causes unexpected b

[Qemu-devel] [PATCH] A different way to ask for readonly drive

2009-12-14 Thread Naphtali Sprei
Hi, After feedback from Red Hat guys, I've decided to slightly modify the approach to drive's readonly. The new approach also addresses the silent fall-back to open the drives' file as read-only when read-write fails (permission denied) that causes unexpected behavior. Instead of the 'readonly' b